-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record Python package versions in GDX files #502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@glatterf42 FYI. I'll request your review once the checklist is complete. |
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
=====================================
Coverage 98.9% 98.9%
=====================================
Files 44 44
Lines 4758 4792 +34
=====================================
+ Hits 4706 4741 +35
+ Misses 52 51 -1
|
khaeru
added a commit
to iiasa/message_ix
that referenced
this pull request
Dec 11, 2023
429104d
to
c5dde37
Compare
glatterf42
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks :)
glatterf42
pushed a commit
to iiasa/message_ix
that referenced
this pull request
Jan 10, 2024
khaeru
added a commit
that referenced
this pull request
Jan 10, 2024
Fix a regression introduced in #502.
2 tasks
glatterf42
pushed a commit
that referenced
this pull request
Jan 10, 2024
Fix a regression introduced in #502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the basic functionality for addressing iiasa/message_ix#747.
The GAMSModel class gains an attribute/parameter (
record_version_packages
) and a method (record_versions()
); the latter is called from within therun()
method. This adds a set to the Scenario that is to be solved, with entries like:(The list of included packages is according to
record_version_packages
, so can be extended by downstream packages, likemessage-ix
, that use or subclass GAMSModel.)How to review
Read the diff and note that the CI checks all pass.
Test together with a message_ix PR to be opened next.
PR checklist