Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pint != 0.24.0 in "pytest" CI workflow #535

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Use pint != 0.24.0 in "pytest" CI workflow #535

merged 2 commits into from
Jun 17, 2024

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jun 17, 2024

Per #534.

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅ CI changes only.
  • Add, expand, or update documentation.
  • Update release notes.

@khaeru khaeru added the ci Continuous integration label Jun 17, 2024
@khaeru khaeru self-assigned this Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.8%. Comparing base (35da509) to head (d4b3fee).
Report is 44 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #535   +/-   ##
=====================================
  Coverage   98.8%   98.8%           
=====================================
  Files         44      44           
  Lines       4796    4796           
=====================================
  Hits        4739    4739           
  Misses        57      57           

@khaeru
Copy link
Member Author

khaeru commented Jun 17, 2024

The macOS jobs all fail with the following. I've filed ts-graphviz/setup-graphviz#630 and will work around by temporarily disabling this for the macOS jobs.

Run ts-graphviz/setup-graphviz@v2
  with:
    macos-skip-brew-update: true
    ubuntu-skip-apt-update: false
  env:
    depth: 100
/usr/local/bin/brew install graphviz
==> Downloading https://ghcr.io/v2/homebrew/core/graphviz/manifests/11.0.0
==> Fetching dependencies for graphviz: jasper, netpbm, gts, gdk-pixbuf, fribidi, pango and librsvg
==> Downloading https://ghcr.io/v2/homebrew/core/jasper/manifests/4.2.4
==> Fetching jasper
==> Downloading https://ghcr.io/v2/homebrew/core/jasper/blobs/sha256:18d3d583cb960f8e4872ffc5b2181b6282f95d2c1ebd3a659d0e0b3edf55bc10
==> Downloading https://ghcr.io/v2/homebrew/core/netpbm/manifests/11.02.09
==> Fetching netpbm
==> Downloading https://ghcr.io/v2/homebrew/core/netpbm/blobs/sha256:1eb8e095b030db593891e7ccd136d035f16f3555b29d97f6df470032f2f92c3a
==> Downloading https://ghcr.io/v2/homebrew/core/gts/manifests/0.7.6_3
==> Fetching dependencies for gts: [email protected]
==> Downloading https://ghcr.io/v2/homebrew/core/python/3.12/manifests/3.12.4
==> Fetching [email protected]
==> Downloading https://ghcr.io/v2/homebrew/core/python/3.12/blobs/sha256:93d81dfa181e6890b6a2baa4fbb4df71b6c061a2dc7823fe0ae12b2ec4b59cc1
==> Fetching gts
==> Downloading https://ghcr.io/v2/homebrew/core/gts/blobs/sha256:946d3f08c41e94c2861e555358fd152df7c069ad8a2a7f621b64b55cfb8ceffb
==> Downloading https://ghcr.io/v2/homebrew/core/gdk-pixbuf/manifests/2.42.12
==> Fetching gdk-pixbuf
==> Downloading https://ghcr.io/v2/homebrew/core/gdk-pixbuf/blobs/sha256:80e5eacf286d8371d7fcc13cc9b79d4612ded6d0db3398c5741790174ae70f85
==> Downloading https://ghcr.io/v2/homebrew/core/fribidi/manifests/1.0.15
==> Fetching fribidi
==> Downloading https://ghcr.io/v2/homebrew/core/fribidi/blobs/sha256:664ed32cf6eb7682b3ff7e86bd4fb3df5f86eb97ebfecf136c6312479c5b15bd
==> Downloading https://ghcr.io/v2/homebrew/core/pango/manifests/1.54.0
==> Fetching pango
==> Downloading https://ghcr.io/v2/homebrew/core/pango/blobs/sha256:11d51f9281cd68d0b8718158df55bc28029e25956f1ad313cae99b31ae130dbb
==> Downloading https://ghcr.io/v2/homebrew/core/librsvg/manifests/2.58.1
==> Fetching librsvg
==> Downloading https://ghcr.io/v2/homebrew/core/librsvg/blobs/sha256:2350745eca6a4b73982e9e8c40f4924f5eff08bb43380f4dda54e2586fa19a71
==> Fetching graphviz
==> Downloading https://ghcr.io/v2/homebrew/core/graphviz/blobs/sha256:e0a790680fbfa22a93b1fc73c7e6f5ca71bc115dacb84cfbf9409c80ee16ec89
==> Installing dependencies for graphviz: jasper, netpbm, gts, gdk-pixbuf, fribidi, pango and librsvg
==> Installing graphviz dependency: jasper
==> Downloading https://ghcr.io/v2/homebrew/core/jasper/manifests/4.2.4
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/0edc7047fdbd9e0fd88f4c5ceed204b57e9b4d4f42c1b1b21c502d68fce31118--jasper-4.2.4.bottle_manifest.json
==> Pouring jasper--4.2.4.ventura.bottle.tar.gz
🍺  /usr/local/Cellar/jasper/4.2.4: 45 files, 1.5MB
==> Installing graphviz dependency: netpbm
==> Downloading https://ghcr.io/v2/homebrew/core/netpbm/manifests/11.02.09
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/1c4be61c6a2db4fdbc7e0252e62cd50fb8296d87a1cc919668ac3c70c6ff7e7f--netpbm-11.02.09.bottle_manifest.json
==> Pouring netpbm--11.02.09.ventura.bottle.tar.gz
🍺  /usr/local/Cellar/netpbm/11.02.09: 417 files, 12.9MB
==> Installing graphviz dependency: gts
==> Downloading https://ghcr.io/v2/homebrew/core/gts/manifests/0.7.6_3
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/0cb7519523b42ff855917c33218c1ef771e3060080fea895de59eb848c833cd1--gts-0.7.6_3.bottle_manifest.json
==> Installing dependencies for gts: [email protected]
==> Installing gts dependency: [email protected]
==> Downloading https://ghcr.io/v2/homebrew/core/python/3.12/manifests/3.12.4
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/2970a992f26f411cf71250ce54eb24411d8b065824b51819da7085559f09ce66--python@3.12-3.12.4.bottle_manifest.json
==> Pouring [email protected]
Error: The `brew link` step did not complete successfully
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite [email protected]

To list all files that would be deleted:
  brew link --overwrite [email protected] --dry-run

Possible conflicting files are:
/usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3
/usr/local/bin/2to3-3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3-3.12
/usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3
/usr/local/bin/idle3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3.12
/usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3
/usr/local/bin/pydoc3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3.12
/usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3
/usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3-config
/usr/local/bin/python3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
/usr/local/bin/python3.12-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12-config
==> /usr/local/Cellar/[email protected]/3.12.4/bin/python3.12 -Im ensurepip
==> /usr/local/Cellar/[email protected]/3.12.4/bin/python3.12 -Im pip install -v --no-
==> Summary
🍺  /usr/local/Cellar/[email protected]/3.12.4: 3,277 files, 63.9MB
==> Installing gts
==> Pouring gts--0.7.6_3.ventura.bottle.tar.gz
🍺  /usr/local/Cellar/gts/0.7.6_3: 27 files, 1.4MB
==> Installing graphviz dependency: gdk-pixbuf
==> Downloading https://ghcr.io/v2/homebrew/core/gdk-pixbuf/manifests/2.42.12
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/51502ca3ad1b3a076e2aec3be882089fbd1c2257b822a0d3c155e23e68a7e70e--gdk-pixbuf-2.42.12.bottle_manifest.json
==> Pouring gdk-pixbuf--2.42.12.ventura.bottle.tar.gz
==> /usr/local/Cellar/gdk-pixbuf/2.42.12/bin/gdk-pixbuf-query-loaders --update-c
🍺  /usr/local/Cellar/gdk-pixbuf/2.42.12: 152 files, 3.8MB
==> Installing graphviz dependency: fribidi
==> Downloading https://ghcr.io/v2/homebrew/core/fribidi/manifests/1.0.15
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/c743b3178050604a607c1ebc433b1b187bb5250afa047857b62467fb9f62249a--fribidi-1.0.15.bottle_manifest.json
==> Pouring fribidi--1.0.15.ventura.bottle.tar.gz
🍺  /usr/local/Cellar/fribidi/1.0.15: 68 files, 703.6KB
==> Installing graphviz dependency: pango
==> Downloading https://ghcr.io/v2/homebrew/core/pango/manifests/1.54.0
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/06c4532b8d175a9098d6a1c5b6b1d2b154b126fef30ddbb5b26791e86b8c9675--pango-1.54.0.bottle_manifest.json
==> Pouring pango--1.54.0.ventura.bottle.tar.gz
🍺  /usr/local/Cellar/pango/1.54.0: 69 files, 3.3MB
==> Installing graphviz dependency: librsvg
==> Downloading https://ghcr.io/v2/homebrew/core/librsvg/manifests/2.58.1
Already downloaded: /Users/runner/Library/Caches/Homebrew/downloads/33310076ed8eb156ee41e99f2dc398e83fffb55bcbf9dfc51dc6145e9bd0ee08--librsvg-2.58.1.bottle_manifest.json
==> Pouring librsvg--2.58.1.ventura.bottle.tar.gz
==> /usr/local/opt/gdk-pixbuf/bin/gdk-pixbuf-query-loaders --update-cache
🍺  /usr/local/Cellar/librsvg/2.58.1: 23 files, 46.4MB
==> Installing graphviz
==> Pouring graphviz--11.0.0.ventura.bottle.tar.gz
🍺  /usr/local/Cellar/graphviz/11.0.0: 283 files, 6.5MB
Error: The process '/usr/local/bin/brew' failed with exit code 1

@khaeru
Copy link
Member Author

khaeru commented Jun 17, 2024

Somehow turning off the setup-graphviz step entirely on the macOS runners allowed the jobs to succeed. I infer that Graphviz is already present on these systems.

@khaeru khaeru merged commit b085f49 into main Jun 17, 2024
21 checks passed
@khaeru khaeru deleted the issue/534 branch June 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant