Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm support for Python 3.13 and drop 3.8 #544

Merged
merged 13 commits into from
Nov 20, 2024
Merged

Confirm support for Python 3.13 and drop 3.8 #544

merged 13 commits into from
Nov 20, 2024

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Sep 24, 2024

Python 3.13 will be released 2024-10-01. This PR is to:

These changes would then be on main and ready for the next release at any time.

How to review

  • Note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A
  • Update release notes.

@khaeru khaeru added enh New features & functionality ci Continuous integration labels Sep 24, 2024
@khaeru khaeru self-assigned this Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (02c887a) to head (dcf15af).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #544     +/-   ##
=======================================
- Coverage   98.9%   98.9%   -0.1%     
=======================================
  Files         44      44             
  Lines       4819    4790     -29     
=======================================
- Hits        4769    4740     -29     
  Misses        50      50             
Files with missing lines Coverage Δ
ixmp/_config.py 96.7% <100.0%> (ø)
ixmp/backend/__init__.py 100.0% <100.0%> (ø)
ixmp/backend/base.py 100.0% <100.0%> (ø)
ixmp/backend/jdbc.py 97.2% <100.0%> (ø)
ixmp/cli.py 100.0% <100.0%> (ø)
ixmp/core/platform.py 98.9% <100.0%> (+<0.1%) ⬆️
ixmp/core/scenario.py 99.6% <100.0%> (+<0.1%) ⬆️
ixmp/core/timeseries.py 98.6% <100.0%> (+<0.1%) ⬆️
ixmp/model/__init__.py 100.0% <100.0%> (ø)
ixmp/model/base.py 100.0% <100.0%> (ø)
... and 11 more
---- 🚨 Try these New Features:

khaeru added a commit that referenced this pull request Sep 24, 2024
glatterf42 pushed a commit that referenced this pull request Oct 28, 2024
khaeru added a commit that referenced this pull request Nov 8, 2024
khaeru added a commit that referenced this pull request Nov 8, 2024
@khaeru khaeru mentioned this pull request Nov 19, 2024
2 tasks
glatterf42 pushed a commit that referenced this pull request Nov 19, 2024
@khaeru
Copy link
Member Author

khaeru commented Nov 19, 2024

There doesn't appear to be any upstream response in the last 2+ months. One possibility is we switch away from this to an alternative that seems to be maintained. Alternatives I'm aware of include:

IIRC pretenders is also a source of flakiness, so a switch could side-step those issues.

@khaeru
Copy link
Member Author

khaeru commented Nov 19, 2024

  • pytest-httpserver —I have not used this, but it shows signs of being actively maintained.

Okay, that was pretty easily done and the tests where it was used are simplified.

@glatterf42
Copy link
Member

Thanks, great news! Especially since the one failed test just failed due to a segfault, so this PR might be complete :)

Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the last test passes :)

ixmp/core/scenario.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much cleaner, thanks :)

@khaeru khaeru merged commit 02dadfa into main Nov 20, 2024
21 checks passed
@khaeru khaeru deleted the python-3.13 branch November 20, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants