port static configs to setup.cfg #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eli-schwartz
commented
Nov 29, 2024
•
eli-schwartz
commented
- Fixes README.rst and CHANGES.rst are installed in wrong location #28
- makes development and maintenance much easier via the use of statically parseable metadata
This reverts commit 6b51403. The commit never made sense. It deleted MANIFEST, but a couple years later MANIFEST.in got added right back, which included the same files MANIFEST did. And the commit added a data_files argument to setup.py which was totally invalid -- it tried to install README.rst as /usr/README.rst which was clearly wrong. The original intention appears to have been to borrow the side effect of data_files, and have the files appear in the sdist so setup.py could read them, but it was the wrong way to do it. Fixes: ikegami-yukino#28
setup.cfg can be freely mixed with setup.py and settings from both are merged together. Using the cfg file, it is possible to encode most metadata statically, and use a few powerful new tools in the process -- in particular, it is no longer necessary to regex the `__init__.py` file for the version, since setuptools can natively extract the relevant property (and yes, it does so without importing the module).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.