Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split home to top/left/right components #531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Asher-Tan
Copy link

贡献者你好

很高兴你能付出自己的时间参与到vue-fabric-editor的共享当中去,相信很多人都因为你提交的代码而收益。

原则

我们希望每次提交尽量小,较大重构除外,确保我们每次的改动影响范围清晰明了,能够方便项目维护者快速的将代码合并到主分支。

确保你的代码与主仓库没有冲突

在PR前,请确保你的代码与主仓库保持同步,可以参考这篇文章

确保你的代码代码能正常打包构建

在PR前,请在本地进行打包构建,并进行功能测试,确保功能正常,且不影响其他功能。

  • [√ ] 代码构建正常

告知项目维护者本次修改的功能

refactor: split home to top/left/right components

@nihaojob
Copy link
Member

nihaojob commented Nov 2, 2024

感谢贡献者参与快图开源项目,当多位贡献者为同一个功能提交 PR时,按如下规则进行评选:

  1. 更快:在【改动代码相同】的情况下,以最先提交的 PR为准。
  2. 更完善:以架构更合理、细节更完善、代码更清晰可扩展,优先选择。
  3. 易判断:如PR 中增加预览地址、更清晰的描述 PR、符合commit 规范,管理员可快速判断改动, 优先选择。

11 月15 日前给出评选结果,请您耐心等待。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants