-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22 #30
Open
SuperConfuserUser
wants to merge
2
commits into
ilanddev:master
Choose a base branch
from
SuperConfuserUser:22
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
22 #30
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletions
9
src/components/small-connector.test.ts → ...ents/bullet-point-connection-icon.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import * as paper from 'paper'; | ||
import { LIGHT_GREY } from '../constants/colors'; | ||
import { SMALL_CONNECTOR_SIZE } from '../constants/dimensions'; | ||
|
||
/** | ||
* Bullet Point Connection Icon Visual Component. | ||
* The small (7px) grey filled circle icon that represents special types of connections or bullet points for labels. | ||
* Used for isolated vApp Network labels or at the end of vApp networks that have no attached VNICs. | ||
*/ | ||
export class BulletPointConnectionIconComponent extends paper.Group { | ||
|
||
// the small filled circle icon | ||
readonly _icon: paper.Path.Circle; | ||
|
||
/** | ||
* Creates a new BulletPointConnectionIconComponent instance. | ||
* | ||
* @param _point the location that the bullet connection icon should be rendered at | ||
*/ | ||
constructor(private _point: paper.Point = new paper.Point(0, 0)) { | ||
super(); | ||
this.position = _point; | ||
this.pivot = new paper.Point(0, 0); | ||
|
||
this._icon = new paper.Path.Circle({ | ||
position: new paper.Point(0, 0), | ||
radius: SMALL_CONNECTOR_SIZE / 2, | ||
fillColor: LIGHT_GREY, | ||
parent: this | ||
}); | ||
} | ||
|
||
get icon(): paper.Path.Circle { | ||
return this._icon; | ||
} | ||
} |
13 changes: 7 additions & 6 deletions
13
src/components/connector.test.ts → src/components/connection-icon.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,31 @@ | ||
import { ConnectorComponent } from './connector'; | ||
import { ConnectionIconComponent } from './connection-icon'; | ||
import { VAPP_BACKGROUND_COLOR, CANVAS_BACKGROUND_COLOR } from '../constants/colors'; | ||
import * as paper from 'paper'; | ||
|
||
describe('connector component', () => { | ||
describe('connection icon component', () => { | ||
|
||
beforeAll(() => { | ||
const canvasEl = document.createElement('canvas'); | ||
paper.setup(canvasEl); | ||
paper.settings.applyMatrix = false; | ||
}); | ||
|
||
test('basic properties', () => { | ||
const position = new paper.Point(0, 0); | ||
const defaultColor = new paper.Color(VAPP_BACKGROUND_COLOR); | ||
const connector = new ConnectorComponent(); | ||
const connector = new ConnectionIconComponent(); | ||
expect(connector.position.x).toBe(position.x); | ||
expect(connector.position.y).toBe(position.y); | ||
expect((connector.connector.fillColor as paper.Color).equals(defaultColor)).toBe(true); | ||
expect((connector.icon.fillColor as paper.Color).equals(defaultColor)).toBe(true); | ||
}); | ||
|
||
test('custom position and fill color', () => { | ||
const position = new paper.Point(-20, 30); | ||
const color = new paper.Color(CANVAS_BACKGROUND_COLOR); | ||
const connector = new ConnectorComponent(position, color); | ||
const connector = new ConnectionIconComponent(position, color); | ||
expect(connector.position.x).toBe(position.x); | ||
expect(connector.position.y).toBe(position.y); | ||
expect((connector.connector.fillColor as paper.Color).equals(color)).toBe(true); | ||
expect((connector.icon.fillColor as paper.Color).equals(color)).toBe(true); | ||
}); | ||
|
||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing a case for when connected and disconnected vnics are out of order