Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imjoy [WIP] #88

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Imjoy [WIP] #88

wants to merge 6 commits into from

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Feb 24, 2020

add an imjoy plugin

@oeway
Copy link

oeway commented Feb 26, 2020

@Fynn Could you point me to an example image? And which model should I try? I have been working on the bioimage.io website and made some progress, now it’s time to put some real model there. Would be great if you can start to send PR to the models repo. My next plan is to make the Ilastik bioengine app work.

@oeway
Copy link

oeway commented Feb 26, 2020

@FynnBe I just tried the code, however, I got an error when I try to load the Unet2D model from bioimage.io: https://bioimage.io/?model=2D%20UNet%20Nuclei%20Broad

ParserError: while parsing a block mapping
  in "/tmp/tmp3eelvz6m/Sigmoid.transformation.yaml", line 1, column 1
expected <block end>, but found '<block mapping start>'
  in "/tmp/tmp3eelvz6m/Sigmoid.transformation.yaml", line 4, column 7

Full stack trace here: https://gist.github.com/oeway/7f32db7384f242cab64fe5e81faf6ce6

@FynnBe
Copy link
Member Author

FynnBe commented Feb 27, 2020

@FynnBe I just tried the code, however, I got an error when I try to load the Unet2D model from bioimage.io: https://bioimage.io/?model=2D%20UNet%20Nuclei%20Broad

ParserError: while parsing a block mapping
  in "/tmp/tmp3eelvz6m/Sigmoid.transformation.yaml", line 1, column 1
expected <block end>, but found '<block mapping start>'
  in "/tmp/tmp3eelvz6m/Sigmoid.transformation.yaml", line 4, column 7

Full stack trace here: https://gist.github.com/oeway/7f32db7384f242cab64fe5e81faf6ce6

I fixed the released unet2d model zip. it should work now

@oeway
Copy link

oeway commented Feb 27, 2020

ok, great, will try.

BTW, do you have a test image included in the zip?

@FynnBe
Copy link
Member Author

FynnBe commented Feb 27, 2020

not yet, I thought I'll add one two in today. would it be sufficient if they are in the zip and the covers field would point to them to show them on the website?

@oeway
Copy link

oeway commented Feb 27, 2020

Great, I think the test image and the covers should be different images. test image is full resolution , perhaps 16bits, which we use to feed into the network, ideally also provide a ground-truth image to validate the result with CI. The cover image is only for display on the website, so it should have low-resolution, small size, sometimes in artistic style.

@FynnBe
Copy link
Member Author

FynnBe commented Feb 27, 2020

sure, but where do we host the cover images? one option would be to add them into the zip as well, another to just make covers a list of urls.
It would be convenient to have them in the zip as well, but I suspect you don't want to unpack the zip packages for the website, so maybe the latter?

@FynnBe
Copy link
Member Author

FynnBe commented Feb 27, 2020

ok, great, will try.

BTW, do you have a test image included in the zip?

no, I suppose we should though... I'm on it

@oeway
Copy link

oeway commented Feb 27, 2020

Right, I would host the cover images together with the yaml (same folder or at least in the same github repo), then get a raw url from github to fill in the yaml.

We will generate the zip file so it will have the cover images in the zip in the near future.

For now, I would add the cover images + test images in the zip file manually.

@FynnBe
Copy link
Member Author

FynnBe commented Feb 27, 2020

would it be possible to construct that raw github link on the fly, from the raw github model.yaml link and the relative file path within that yaml... ?
https://github.com/bioimage-io/pytorch-bioimage-io/tree/master/specs/models/unet2d/nuclei_broad

@oeway
Copy link

oeway commented Feb 27, 2020

Yes, we are doing that, in the yaml you can use relative path to the cover image/readme etc., we have code to resolve it.

@oeway
Copy link

oeway commented Feb 28, 2020

FYI: I made a BioEngine App based on your example, and it runs smoothly in ImJoy with MyBinder: bioimage-io/bioimage-io-resources#7

75494895-8f888000-59bd-11ea-84e1-7254d9e14855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants