1 Correct option handling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable. |
jlevon
pushed a commit
that referenced
this pull request
Jan 7, 2020
There were a bunch of missing parts from the floating point support. #1) It wasn't recording floating point parameters correctly in the DB because sval_to_numstr() wasn't updated. #2) It wasn't parsing the floating points from the DB correctly because parse_val() wasn't updated. #3) It wasn't reading floating point expressions EXPR_FVALUE in smatch_math.c or displaying them correctly in smatch_helper.c #4) Casting from a float to an int was broken. I deleted cast_rl_fp() because that was redundant. Reported-by: John Levon <[email protected]> Signed-off-by: Dan Carpenter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this with the --succeed option on a full illumos build.