Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream and allow engines #244

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+12 −9
Open

Upstream and allow engines #244

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
264d33f
feat: fix generation when engines define data migrations path
gustavodiel Sep 23, 2022
dd6378c
feat: support engines
gustavodiel Sep 23, 2022
0962f3a
Merge pull request #1 from trusted/fndsit/allow-engines
chrisblatchley Jan 30, 2023
9aefda5
feat: fix generation when engines define data migrations path
gustavodiel Sep 23, 2022
9d81103
feat: support engines
gustavodiel Sep 23, 2022
73ce67b
Merge branch 'master' of github.com:trusted/data-migrate
chrisblatchley Jan 31, 2023
3807de4
fix: iterate through migration dirs
chrisblatchley Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/data_migrate/config.rb
View file
Original file line number Diff line number Diff line change
@@ -12,12 +12,13 @@ def config
end

class Config
attr_accessor :data_migrations_path, :data_template_path, :db_configuration, :spec_name
attr_accessor :data_migrations_path, :data_migrations_gen_path, :data_template_path, :db_configuration, :spec_name

DEFAULT_DATA_TEMPLATE_PATH = "data_migration.rb"

def initialize
@data_migrations_path = "db/data/"
@data_migrations_gen_path = "db/data"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does gen stand for? do you mind adding it to the docs as well. also, please rebase with main, at some point travisci tests stopped running to i switched to github actions

@data_template_path = DEFAULT_DATA_TEMPLATE_PATH
@db_configuration = nil
@spec_name = nil