Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BarChart isn't fit to the visibility of its #1387

Closed
wants to merge 2 commits into from
Closed

Fix BarChart isn't fit to the visibility of its #1387

wants to merge 2 commits into from

Conversation

sownt
Copy link
Contributor

@sownt sownt commented Jul 14, 2023

It's cause of minY value from BarChartHelper always 0.0 if any fromY of BarChartData is positive. So min value of Y-axis always starts from 0.0 or a negative value.

I update minY value of chart to min of fromY any values of ChartData. This is result of my change, Line 1 will be hide and Y-axis will start from 150.

Frame 1

I also update bar_chart_painter_test for its.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1387 (5a06f90) into master (478e5e6) will increase coverage by 0.43%.
Report is 9 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   86.09%   86.52%   +0.43%     
==========================================
  Files          45       45              
  Lines        2978     2984       +6     
==========================================
+ Hits         2564     2582      +18     
+ Misses        414      402      -12     
Files Changed Coverage Δ
lib/src/chart/bar_chart/bar_chart_helper.dart 97.14% <100.00%> (+0.26%) ⬆️
lib/src/chart/bar_chart/bar_chart_painter.dart 96.12% <100.00%> (+3.94%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imaNNeo
Copy link
Owner

imaNNeo commented Aug 21, 2023

I did some changes to this (merged) MR
Please check the master branch and let me know what do you think about it.

@imaNNeo imaNNeo closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants