-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New property PieChartData.titleSunbeamLayout to rotate the titles of each section of the chart #1582
Conversation
…each section of the chart
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
- Coverage 86.38% 86.29% -0.09%
==========================================
Files 45 45
Lines 3047 3051 +4
==========================================
+ Hits 2632 2633 +1
- Misses 415 418 +3 ☔ View full report in Codecov by Sentry. |
Also, you need to write some unit-tests |
I made a typo on the upper limit to rotate the title, well-trained eye 😃 I also wrote some unit tests and made some other minor adjustments, let's see now. |
Thank you so much! |
Done @imaNNeo |
Thanks for your contribution! |
The idea is taken from the following library, property
labelSunbeamLayout
: https://krispo.github.io/angular-nvd3/#/pieChartYou can set the property
titleSunbeamLayout
inPieChartData
to rotate the titles.By default is set to
false
to not modify any existing code:By if you set it
true
it'll look like this:This is specially useful for large sets of data where titles can easily overlap.