Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining axisTitleData references #1596

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JoshMart
Copy link
Contributor

@JoshMart JoshMart commented Mar 1, 2024

There are old references to the outdated axisTitleData in the docs and in some code comments after it was removed. Two issues were opened to ask about these missing properties: #1259 and #1201. This PR cleans up all remaining code and doc references to axisTitleData.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (930ac12) to head (fa40aaf).
Report is 8 commits behind head on main.

❗ Current head fa40aaf differs from pull request most recent head 3d803d8. Consider uploading reports for the commit 3d803d8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          45       45           
  Lines        3078     3078           
=======================================
  Hits         2694     2694           
  Misses        384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshMart JoshMart changed the title Remove axis title data from bar chart docs Remove remaining axisTitleData references Mar 1, 2024
@imaNNeo
Copy link
Owner

imaNNeo commented Mar 28, 2024

Thank you so much!
It's ready to be merged. Please resolve the CHANGELOG conflict first.

@JoshMart
Copy link
Contributor Author

Thank you so much! It's ready to be merged. Please resolve the CHANGELOG conflict first.

You got it. Conflicts should be resolved now.

@imaNNeo
Copy link
Owner

imaNNeo commented May 9, 2024

Sorry, I just updated the CHANGELOG some minutes ago, so I saw the conflict here again and I tried to fix it. But it seems it isn't fixed, can you please revert your change in the CHANGELOG?
I will write it by myself.

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 20, 2024

Hello? any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants