-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Reader
to ImageReader
#2243
Rename Reader
to ImageReader
#2243
Conversation
Created #2245 to track issues like this that'll need a breaking release |
I think it'd be helpful to create a pub use under old name with a deprecated attribute. It makes migration less painful. |
I'm not sure you can place a deprecated attribute on a re-export. But in either case, in the future @kornelski let's avoid merging breaking changes directly to the main branch. I'd prefer to keep the main branch in a state where it is always possible to make a patch release if needed. We can discuss major release strategy more in the linked issue, but I wasn't planning to start it for another 6+ months. |
The attribute needs to be on |
@ripytide could you open a PR with the necessary re-export? I'd also like to give @HeroicKatora a chance to weigh in. They had some concerns with the renaming before, and while they've been less active recently they are still a maintainer. |
The previous design is to large parts modelled around the standard library, that is small modules and avoid prefix duplication (the library is |
I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.
Following the discussion from #1327