Fix robot page exception on TypeError: Cannot read properties of unde…

…fined (reading 'cohort') (microsoft#2540) * fix robot page exception on TypeError: Cannot read properties of undefined (reading 'cohort') in .filter * Update ChartConfigurationFlyout.tsx * Update ModelAssessmentDashboard.tsx
imatiach-msft · May 21, 2024 · 1570b17 · 1570b17
1 parent 6898acd
commit 1570b17
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/...ment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ChartConfigurationFlyout.tsx b/...ment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ChartConfigurationFlyout.tsx
@@ -68,9 +68,9 @@ export class ChartConfigurationFlyout extends React.Component<
       // maximum which indicates that new cohorts were created.
       newCohorts = this.props.datasetCohorts
         .filter(
-          (errorCohort) => errorCohort.cohort.getCohortID() > prevMaxCohortID
+          (errorCohort) => errorCohort?.cohort?.getCohortID() > prevMaxCohortID
         )
-        .map((errorCohort) => errorCohort.cohort.getCohortID());
+        .map((errorCohort) => errorCohort?.cohort?.getCohortID());
     }
 
     // reset feature-based cohort selection if the underlying feature-based cohorts changed

diff --git a/...sment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ModelOverviewChartPivot.tsx b/...sment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ModelOverviewChartPivot.tsx
@@ -83,12 +83,12 @@ export class ModelOverviewChartPivot extends React.Component<
       // only keep selected stats and cohorts based on cohort ID
       labeledStatistics = this.props.labeledStatistics.filter((_, i) =>
         this.props.selectedChartCohorts.includes(
-          chartCohorts[i].cohort.getCohortID()
+          chartCohorts[i]?.cohort.getCohortID()
         )
       );
       chartCohorts = chartCohorts.filter((errorCohort) =>
         this.props.selectedChartCohorts.includes(
-          errorCohort.cohort.getCohortID()
+          errorCohort?.cohort.getCohortID()
         )
       );
     } else {

diff --git a/libs/model-assessment/src/lib/ModelAssessmentDashboard/ModelAssessmentDashboard.tsx b/libs/model-assessment/src/lib/ModelAssessmentDashboard/ModelAssessmentDashboard.tsx
@@ -369,7 +369,7 @@ export class ModelAssessmentDashboard extends CohortBasedComponent<
       return;
     }
     const newCohorts = [...this.state.cohorts].filter(
-      (t) => t.cohort.name !== cohort.cohort.name
+      (t) => t?.cohort?.name !== cohort?.cohort?.name
     );
     this.setState({
       cohorts: newCohorts