Endpoint Interruption Logic for Model Overview with OD (microsoft#2268)

* endpoint interruption working ckpt * auto lint fixes
imatiach-msft · Aug 24, 2023 · 798e9d5 · 798e9d5
1 parent a714c25
commit 798e9d5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/...odel-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ModelOverview.tsx b/...odel-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ModelOverview.tsx
@@ -88,6 +88,7 @@ interface IModelOverviewState {
   featureBasedCohortLabeledStatistics: ILabeledStatistic[][];
   featureBasedCohorts: ErrorCohort[];
   iouThreshold: number;
+  objectDetectionAbortController: AbortController | undefined;
 }
 
 const datasetCohortViewPivotKey = "datasetCohortView";
@@ -125,6 +126,7 @@ export class ModelOverview extends React.Component<
       featureConfigurationIsVisible: false,
       iouThreshold: 70,
       metricConfigurationIsVisible: false,
+      objectDetectionAbortController: undefined,
       selectedFeatures: [],
       selectedFeaturesContinuousFeatureBins: {},
       selectedMetrics: [],
@@ -362,6 +364,7 @@ export class ModelOverview extends React.Component<
                 setIoUThreshold={this.setIoUThreshold}
                 updateDatasetCohortStats={this.updateDatasetCohortStats}
                 updateFeatureCohortStats={this.updateFeatureCohortStats}
+                abortController={this.state.objectDetectionAbortController}
               />
             )}
           </Stack>
@@ -650,14 +653,16 @@ export class ModelOverview extends React.Component<
       this.state.className.length > 0 &&
       this.state.iouThreshold
     ) {
+      const newAbortController = new AbortController();
+      this.setState({ objectDetectionAbortController: newAbortController });
       this.context
         .requestObjectDetectionMetrics(
           selectionIndexes,
           this.state.aggregateMethod,
           this.state.className,
           this.state.iouThreshold,
           this.objectDetectionCache,
-          new AbortController().signal
+          newAbortController.signal
         )
         .then((result) => {
           const [allCohortMetrics, cohortClasses] = result;

diff --git a/.../src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ObjectDetectionModelOverview.tsx b/.../src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ObjectDetectionModelOverview.tsx
@@ -55,6 +55,7 @@ export interface IObjectDetectionWidgetsProps {
   setIoUThreshold: (value: number) => void;
   updateDatasetCohortStats: () => void;
   updateFeatureCohortStats: () => Promise<void>;
+  abortController: AbortController | undefined;
   telemetryHook?: (message: ITelemetryEvent) => void;
 }
 
@@ -115,11 +116,18 @@ export class ObjectDetectionWidgets extends React.PureComponent<IObjectDetection
     );
   }
 
+  private abortAnyPreexistingExecution(): void {
+    if (this.props.abortController !== undefined) {
+      this.props.abortController.abort();
+    }
+  }
+
   private onAggregateMethodChange = (
     _: React.FormEvent<IComboBox>,
     item?: IComboBoxOption
   ): void => {
     if (item) {
+      this.abortAnyPreexistingExecution();
       this.props.setAggregateMethod(item.text.toString());
     }
   };
@@ -129,12 +137,14 @@ export class ObjectDetectionWidgets extends React.PureComponent<IObjectDetection
     item?: IComboBoxOption
   ): void => {
     if (item) {
+      this.abortAnyPreexistingExecution();
       this.props.setClassName(item.text.toString());
     }
   };
 
   private onIoUThresholdChange = (_: React.MouseEvent, value: number): void => {
     if (value) {
+      this.abortAnyPreexistingExecution();
       this.props.setIoUThreshold(value);
     }
   };