Changes by ChibiShibe #54

chibishibe · 2018-02-23T21:32:12Z

Re-instated the following behaviors:
-Greet
-Eventbrite
-countdown

Changes to Greet:
indexed it
Added personality

Changes to eventbrite:
Re-instated Token
Re-instated no peek function
Added heightened personality to no peek

Changes to Clap:
Changed Class name to fit behaviour

Changes to countdown:
Fixed Time format, stopped console error

~~New additions
"Do the impossible" behavior key-phrase response
-Reference to TTGL anime show
"Shake"
-Converts messages sent via "!shake" to Gif emoji varients"

~~Other changes
Swapped icons around, Began centralizing

drat

Let's try this shall we? Duped Section that normally scream when you roll more than 100

It kept spitting out "(Please enter number of dice being rolled and Number of Sides like "!rtd 1d5)" for every roll because input.

1d100 function reply doesn't work No input still returning null

UGH, Reverted to baseline

yee

test 1/1 succeed

Test

Gave a little personality

because promises amiright?

Derp Soon

Changed keys and tokens. LET'S FIRE

Response back

weee

Added Greet

whoops Round 2

back to planet, remove the space

no space here either

lets try a comma

Back to square 1?

not a total revision

Zero

goddamnitall

damndamnda

Turns out we might need it?

killme

(guarantee that logging goes to muh terminal thx)

imjoshdean

A lot of non-difficult changes. Looking good, just needs polish!

imjoshdean · 2018-02-27T01:06:31Z

package.json

@@ -48,6 +48,8 @@
    "rimraf": "^2.5.2"
  },
  "dependencies": {
+    "airtable": "^0.5.2",


This isn't being used, please remove.

Oh shoot, this PR's off a branch, isn't it...
That's in place pending implementation as a Karma backend (soon).
If you want, we can revert and drop a branch with this deleted at ~that point in time :)

You can also just throw up another commit removing the dependencies, less work for you.

imjoshdean · 2018-02-27T01:06:35Z

package.json

@@ -48,6 +48,8 @@
    "rimraf": "^2.5.2"
  },
  "dependencies": {
+    "airtable": "^0.5.2",
+    "eslint-plugin-jsx-a11y": "^6.0.3",


This isn't being used, please remove.

imjoshdean · 2018-02-27T01:07:40Z

src/behaviors/clap/clap.js

@@ -1,28 +1,28 @@
 import Behavior from '../behavior.js';

-class RollTheDice extends Behavior {
+class ClaporRave extends Behavior {


Capitalize your "o" with CamelCase you capitalize every letter. So ClapOrRave

imjoshdean · 2018-02-27T01:08:06Z

src/behaviors/clap/clap.js

  constructor(settings) {
-    settings.name = 'Clap Hype';
-    settings.description = `'cause 👏 sometimes 👏 you 👏 need 👏 emphasis!`;
+    settings.name = 'ClappingRave';


Split these words, the name is more meant to be user readable.

imjoshdean · 2018-02-27T01:08:59Z

src/behaviors/clap/clap.js

-    });
+    ['clap', 'rubyrave', 'wut'].forEach(emoji => this.commands.push({
+      tag: emoji,
+      description: `I'll hype your message, !Clap or !Rave`


Will !Clap work, or only !clap? You should make sure what users see is what they can use. I've tried to strive for all lower case for these where possible.

Agreed, Pesky Shift Trigger Finger.

Will lowercase

imjoshdean · 2018-02-27T01:18:29Z

src/behaviors/shake/array/Alphaarray.js

@@ -0,0 +1,2 @@
+var letters = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"].map(alpha => ":sh-" + alpha + ":");


This file can be deleted, as it is not used.

imjoshdean · 2018-02-27T01:19:48Z

src/behaviors/shake/shake.js

+
+  parseMessage(message, channel, data) {
+   let splitMessage = message.replace(/^!shake/gi, '')
+   		.replace(/\:\w*\:/gi, '')


Let's bring down the indentation a bit, only needs to be two spaces from the let. 👌

imjoshdean · 2018-02-27T01:20:11Z

src/behaviors/shake/shake.js

+		.replace(/[^a-zA-Z ]/g, '')
+		.trim()
+		.split('');
+	  if( splitMessage.length > 20) {


Trim the spacing before splitMessage

imjoshdean · 2018-02-27T01:20:49Z

src/behaviors/shake/shake.js

+	  }
+
+const parsedMessage = splitMessage.map(alpha => alpha == " " ? ":ws:" : `:sh-${alpha}:`);
+


Unnecessary whitespace. In general this file has some wonky spacing on it. Try and clean it up, tab === two spaces please.

Other things I'm noticing, please use single quotes, not double quotes throughout.

imjoshdean · 2018-02-27T01:22:14Z

src/index.js

@@ -23,8 +31,8 @@ const mascot = new MascotBot({
    {
      behavior: DaysUntil,
      settings: {
-        conDate: '8/11/2017',
-        maxDays: 398,
+        conDate: '2018-07-26 09-05:00',


This isn't a valid date. Maybe stick to a simpler format.

Our local test disagrees '-'
That's not quite ISO 8601, but I believe the library which supports parsing those to times was complaining that the previous version was going to be deprecated, so we saw to it to change it to this form. (It's missing MM:SS and T, isn't it :)
ISO 8601 is pretty unambiguous, would you prefer it in proper form instead?

Sorry, I didn't realize that was ISO-8601, as long as moment has no problems with it!

Yeah, when I went to run the countdown behaviour for the first time. I encountered a Depreciation Warning in console. It worked, it just threw a warning out, so I tweaked the format a bit in order to keep a clean console

clap -> Changed to emp, added functionality days until -> Changed errors in indent eventbrite - > Added correct amount of periods for ellipsis personality greet -> changed to lowercase for icon introductions -> reverted all changed to intoductions and messages messages -> see above Removed rave structure -> combined into changed emp Removed array -> No longer needed shake.js -> Fixed indenting and removed whitespace indec -> Removed rave entry, added emp

Index.js -> Forgot to remove clap.js changed to emp.js

imjoshdean

Still a lot of changes suggested not yet implemented, and a few more from here.

imjoshdean · 2018-02-27T15:13:19Z

src/behaviors/emp/emp.js

@@ -1,22 +1,22 @@
 import Behavior from '../behavior.js';

-class ClaporRave extends Behavior {
+class Emp extends Behavior {


Please use meaningful names and try to refrain from confusing abbreviations or shortened versions of words. While you might understand what they mean, other developers may not. Emphasis would be easier to understand.

imjoshdean · 2018-02-27T15:14:55Z

src/behaviors/shake/shake.js

-const parsedMessage = splitMessage.map(alpha => alpha == " " ? ":ws:" : `:sh-${alpha}:`);
-
+    let splitMessage = message.replace(/^!shake/gi, '')
+    .replace(/\:\w*\:/gi, '')


This one is my bad for not being the clearest, you should definitely indent, but generally it's one tab off the current indentation so rather than

let splitMessage = message.replace(/^!shake/gi, '') .replace(/\:\w*\:/gi, '')

let splitMessage = message.replace(/^!shake/gi, '') .replace(/\:\w*\:/gi, '') ``

Removed non-current dependencies from package. ((airtable + eslint)) Changed name of "emp" to "emphasis" to improve clarity Fixed indenting on 1:1 scale with shake replaced changes in index ((Emp -> emphasis))

GitCola will be my GitGui on Raspberri Pi, I need to test a commit -Tweak response to greet.js

Post help in only one message Tested, working correctly. Merging

chibishibe and others added 30 commits February 21, 2018 13:15

making changes for API

4616670

changed con Date

d6ccdcc

testing Null return fix

d9252c4

undo test fix for Null

5d12bbd

drat

Null roll fix Test 2

9371b9e

Let's try this shall we? Duped Section that normally scream when you roll more than 100

Changed Line 53 to specify Less than 1 for input

e2c7d8d

It kept spitting out "(Please enter number of dice being rolled and Number of Sides like "!rtd 1d5)" for every roll because input.

Dice

9192cb0

1d100 function reply doesn't work No input still returning null

Revert changes to original ((rtd fix test))

b028be9

UGH, Reverted to baseline

slight edit to test git pull

425af0e

yee

change back to finalize git pull test

4ec8e04

test 1/1 succeed

No peeking

20b9027

Test

Changed icon

a8e62d7

added character1

9370478

Gave a little personality

EVEN MORE CHARACTER

feb7e58

because promises amiright?

added more response

5f73ecc

Derp Soon

Removed Peek, Testing EventBrite

744bd25

Changed keys and tokens. LET'S FIRE

Put lock on

fc85865

Response back

shortend and hid link

9337479

weee

Greet addition

e94cd3b

Added Greet

Forgot a " ' "

782d7d5

whoops Round 2

removed space

5c89fbe

back to planet, remove the space

Space removed

0ed3d78

no space here either

comma?

3942754

lets try a comma

remove other things

67efda9

Back to square 1?

fresh?

0c84db5

not a total revision

Square 0

a374542

Zero

rd 2 fresh

acadc9f

goddamnitall

rd3

7755877

damndamnda

space put back

f36f0fa

Turns out we might need it?

rd4

d24b152

killme

chibishibe added 22 commits February 25, 2018 21:49

Update days-until.js

2b09579

Change bot.log to console.log

ee92c69

(guarantee that logging goes to muh terminal thx)

Update time

3b04d23

check return of _api

e303a6a

yay

856a376

Update days-until.js

e751050

Update days-until.js

590443f

Test

a234b48

Update days-until.js

6a7cabf

Update days-until.js

3a24a02

Update days-until.js

527c159

Update days-until.js

9898f5d

Update random-channel.js

e9b230f

Update random-channel.js

4d3dff3

Create RubyRave

8693957

added rave

29761c0

Rename rave to rave.js

f96374d

Delete RubyRave

fb9c6d8

Rename src/behaviors/Rave/rave.js to src/behaviors/rave/rave.js

7991562

Update index.js

0ce7a36

Update rave.js

9711215

Update clap.js

cda3f46

imjoshdean requested changes Feb 27, 2018

View reviewed changes

chibishibe added 2 commits February 26, 2018 21:45

Launch Error, immediate fix

428b9cc

Index.js -> Forgot to remove clap.js changed to emp.js

imjoshdean requested changes Feb 27, 2018

View reviewed changes

chibishibe and others added 4 commits February 27, 2018 13:56

-/+ log, (emp)(indentShake)(dependencies)

430c847

Removed non-current dependencies from package. ((airtable + eslint)) Changed name of "emp" to "emphasis" to improve clarity Fixed indenting on 1:1 scale with shake replaced changes in index ((Emp -> emphasis))

This is a test of GitCola

552156c

GitCola will be my GitGui on Raspberri Pi, I need to test a commit -Tweak response to greet.js

Post help in only one message

c81b119

Merge pull request #2 from chibishibe/single_help_msg

942b276

Post help in only one message Tested, working correctly. Merging

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes by ChibiShibe #54

Changes by ChibiShibe #54

chibishibe commented Feb 23, 2018

imjoshdean left a comment

imjoshdean Feb 27, 2018

Grissess Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

chibishibe Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

Grissess Feb 27, 2018

imjoshdean Feb 27, 2018

chibishibe Feb 28, 2018

imjoshdean left a comment

imjoshdean Feb 27, 2018

imjoshdean Feb 27, 2018

		@@ -0,0 +1,2 @@
		var letters = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v", "w", "x", "y", "z"].map(alpha => ":sh-" + alpha + ":");

		}

		const parsedMessage = splitMessage.map(alpha => alpha == " " ? ":ws:" : `:sh-${alpha}:`);

Changes by ChibiShibe #54

Are you sure you want to change the base?

Changes by ChibiShibe #54

Conversation

chibishibe commented Feb 23, 2018

imjoshdean left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imjoshdean left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment