feat: add QR code for shared link #13128
Conversation
|
this time i am using svelte-qrcode to generate the QR code and its being added as module, not as library. Hope that's better now |
...src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte
Outdated
Show resolved
Hide resolved
...src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte
Outdated
Show resolved
Hide resolved
danieldietzler
changed the title
|
Also, please fix the typescript issues. |
|
Hello, thank you for the PR. What is the use case of this PR? How are you planning to share the QR code? |
|
hi @alextran1502 , my use case is as follows - i shoot people on the street and when i am done i create album and share that code over phone to the person who will later have photos there for download. I dont share any phone numbers or contact details to send link later. I understand that this is a change in UI and not everyone would like to have it always on - if you want i will try to add switch to User settings (feature toggle) and by default QR code would be disabled. Second option would be to click on "generate QR" button once link is created. This way it would be less "pushy" feature |
|
I think having a button to generate the QR code upon request is a good idea. Also it would be useful to be able to share the QR code as image would be beneficial to send the code to different users, or to print it |
Simple patch to add QR code to the dialog where link for album sharing is generated