fixed the local ids selecting issue #13256
Conversation
|
@mertalev Please add someone to review |
|
@shenlong-tanwen updated the implementation inside the |
This reverts commit 04f2ed5.
|
@shenlong-tanwen Any update on review ? |
There was a problem hiding this comment.
You could do one of the following:
i) You could use your previous implementation of having the filtering logic in the widget and remove all the filtering logic in the provider as it is redundant and has errors
ii) Fix the logical issue in the provider and remove your filtering logic and toast handling in the widget as the assets are already filtered in the provider
Also fix any issues from the dart analyzer as well
Apologies for not being more clearer with the previous comment. Thanks for working on this.
|
Thanks @shenlong-tanwen , I have updated the logic as per requirement. And, also removed UI logic from the provider code, as you mentioned and have implemented it from code perpective |
|
|
||
| // Trigger a refresh to update the UI after deletion | ||
| await ref.read(assetProvider.notifier).getAllAsset(); |
There was a problem hiding this comment.
Why is this needed?
@yashrajjain726 Gentle reminder
|
@yashrajjain726 The changes are good. Can you respond to the only remaining comment on why the refresh is needed? |
|
@shenlong-tanwen I have replied to it long time ago, please check. |
Fixed #11428