Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(users): add email to MergeIdentifier object #56

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

antonioturdo
Copy link
Collaborator

🚨 Proposed changes

Add email and prioritization to MergeIdentifier object according to https://www.braze.com/docs/api/endpoints/user_data/post_users_merge/

⚙️ Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Refactor

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (51b1810) to head (7b98f47).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #56   +/-   ##
=========================================
  Coverage     99.57%   99.57%           
- Complexity      494      500    +6     
=========================================
  Files           139      139           
  Lines           939      947    +8     
=========================================
+ Hits            935      943    +8     
  Misses            4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonioturdo antonioturdo merged commit 21016ae into main Apr 3, 2024
8 checks passed
@antonioturdo antonioturdo deleted the feat/merge-by-email branch April 3, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants