Minor fix: Inconsistent CellDeriv for T-cell derived annotations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The very first T-cell derived annotation has "T.cell" as the value of CellDeriv, while _all other_ T-cell derived annotations use "T[space]cell". This means that any end-user who groups data by CellDeriv will mistakenly create two separate groups for the annotation ID=1 and the rest T-cell annotations.
|
That is a very good point, thank you for catching this!
Best,
Tiffany
…On Fri, Mar 18, 2022 at 7:25 AM Dmitrii Borisevich ***@***.***> wrote:
The very first T-cell derived annotation has "T.cell" as the value of
CellDeriv, while *all other* T-cell derived annotations use
"T[space]cell".
This means that any end-user who groups data by CellDeriv will mistakenly
create two separate groups for the annotation ID=1 and the rest T-cell
annotations.
------------------------------
You can view, comment on, or merge this pull request online at:
#7
Commit Summary
- 04882ed
<04882ed>
Minor fix: Inconsistent CellDeriv for T-cell derived annotations
File Changes
(1 file <https://github.com/immunogenomics/IMPACT/pull/7/files>)
- *M* IMPACT707/IMPACT_annotation_key.txt
<https://github.com/immunogenomics/IMPACT/pull/7/files#diff-79285de65e2b61e69d204c252e1e8abf0f491ebb927512f4f2df6d40355db069>
(2)
Patch Links:
- https://github.com/immunogenomics/IMPACT/pull/7.patch
- https://github.com/immunogenomics/IMPACT/pull/7.diff
—
Reply to this email directly, view it on GitHub
<#7>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBTQRBBFAQJFYRTA5QULHTVARR2XANCNFSM5RBR67UA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Tiffany Amariuta-Bartell, PhD
Postdoctoral Researcher
Department of Epidemiology
Harvard T.H. Chan School of Public Health
|
|
Hi Tiffany, If you agree with this (very minor) PR, could you merge it into the master branch so that the files in the repo are updated? Best wishes, Dimi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The very first T-cell derived annotation has "T.cell" as the value of CellDeriv, while all other T-cell derived annotations use "T[space]cell".
This means that any end-user who groups data by CellDeriv will mistakenly create two separate groups for the annotation ID=1 and the rest T-cell annotations.