Minor fix: Copy-paste issue in the list of used baselineLD annotations #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file mentions an annotation named "H3K4me1_Trynka.extend.50H3K4me3_peaks_Trynka". There is no such annotation in baselineLD, but there are two annotations called "H3K4me1_Trynka.extend.500" and "H3K4me3_peaks_Trynka" that go one after another in baselineLD list. I think that a glitch happened when the list of used annotations was copy-pasted to this repo after the analysis was done, causing a merger of the two sequential lines. It seems unlikely to me that this has affected the original analysis. This PR fixes this merger (and also changes the name of the file accordingly).
|
The "Files changed" tab indicates that the last line of the file was also changed, but that is not correct. The last line was left untouched. |
|
Thank you so much for finding this discrepancy!
Best,
Tiffany
…On Fri, Mar 18, 2022 at 7:36 AM Dmitrii Borisevich ***@***.***> wrote:
The "Files changed" tab indicates that the last line of the file was also
changed, but that is not correct. The last line was left untouched.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBTQREWLYFMR47LEZOJ6D3VARTFTANCNFSM5RBSWG2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Tiffany Amariuta-Bartell, PhD
Postdoctoral Researcher
Department of Epidemiology
Harvard T.H. Chan School of Public Health
|
|
Hi Tiffany, If you agree with this (very minor) PR, could you merge it into the master branch so that the files in the repo are updated? Best wishes, Dimi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file mentions an annotation named "H3K4me1_Trynka.extend.50H3K4me3_peaks_Trynka". There is no such annotation in baselineLD, but there are two annotations called "H3K4me1_Trynka.extend.500" and "H3K4me3_peaks_Trynka" that go one after another in baselineLD list.
I think that a glitch happened when the list of used annotations was copy-pasted to this repo after the analysis was done, causing a merger of the two sequential lines. It seems unlikely to me that this has affected the original analysis.
This PR fixes this merger (and also changes the name of the file accordingly from 69 to 70 annotations).