Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testando módulo controllers.file #37

Merged
merged 3 commits into from
May 20, 2020
Merged

Testando módulo controllers.file #37

merged 3 commits into from
May 20, 2020

Conversation

rodrigondec
Copy link
Member

closes #31

@rodrigondec rodrigondec changed the title Testando módulo file Testando módulo controllers.file May 18, 2020
Copy link
Contributor

@PedroRegisPOAR PedroRegisPOAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algo que já pensei a algum tempo é que talvez não fosse preciso escrever as linhas como uma lista, mas sim como uma string com os \n no meio, isso facilitaria várias coisas, exceto achar erros. Mas funções como a que junta os pieces não seriam mais necessárias, nem escrever no arquivo linha a linha, mas sim de uma só vez a string já com os \n. Se achar pertinente abre uma issue sobre isso.

tests/controllers/test_file.py Show resolved Hide resolved
tests/controllers/test_file.py Show resolved Hide resolved
tests/controllers/test_file.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #37 into master will increase coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   71.15%   72.04%   +0.89%     
==========================================
  Files          15       15              
  Lines         669      669              
==========================================
+ Hits          476      482       +6     
+ Misses        193      187       -6     
Impacted Files Coverage Δ
icnab240/controllers/file.py 100.00% <0.00%> (+66.66%) ⬆️
Impacted Files Coverage Δ
icnab240/controllers/file.py 100.00% <0.00%> (+66.66%) ⬆️

@rodrigondec rodrigondec merged commit f0fbe93 into master May 20, 2020
@rodrigondec rodrigondec deleted the feature/test-file branch May 20, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testar controllers.file
2 participants