fix: switch to UserSerializer for followedUsers relationship
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was brought to my attention, that sometimes user data on the
followedUserspage is missing / inconsistent. When hard refreshing the page, some of the relations are missing and wrong or no data is displayed in the UserCard. Only after navigating to a user in the list and navigating back, the data was correctly populated. It appears that it has been an issue since this PR https://github.com/imorland/follow-users/pull/33/filesThis issue is reproducible with just flarum/core, fof/follow tags & ianm/follow-users (the joined at date will initially always say "joined a few seconds ago"). The issue is more noticeable when data of other extensions are missing (such as
fof/best-answer).Using
BasicUserSerializer(before):Using
UserSerializer(after):This will impact performance, but I think it's unavoidable to switch the Serializer.