Skip to content

Commit

Permalink
More tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
@paddycarver
paddycarver committed Dec 28, 2024
1 parent 5d3fc42 commit 6282a61
Show file tree
Hide file tree
Showing 2 changed files with 206 additions and 0 deletions.
143 changes: 143 additions & 0 deletions flag_reflect_number_big_test.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
package clif

import (
"context"
"errors"
"math"
"math/big"
"reflect"
"strconv"
"testing"
)

func TestNewValueFromBigInt_success(t *testing.T) {
t.Parallel()

type testCase struct {
input FlagValue
expected *big.Int
target any
}
testCases := map[string]testCase{
// *big.Int
"*big.Int/0": {input: FlagValue{Set: true, Raw: "0"}, expected: big.NewInt(0), target: big.NewInt(0)},
"*big.Int/-1": {input: FlagValue{Set: true, Raw: "-1"}, expected: big.NewInt(-1), target: big.NewInt(0)},
"*big.Int/1": {input: FlagValue{Set: true, Raw: "1"}, expected: big.NewInt(1), target: big.NewInt(0)},
"*big.Int/max-int": {input: FlagValue{Set: true, Raw: strconv.FormatInt(math.MaxInt64, 10)}, expected: big.NewInt(math.MaxInt64), target: big.NewInt(0)},
}
for name, test := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()

ctx := context.Background()

res, err := newValueFromBigInt(ctx, test.input, reflect.ValueOf(test.target))
if err != nil {
t.Fatalf("Unexpected error %s", err)
}
got := res.Interface().(*big.Int)

Check failure on line 38 in flag_reflect_number_big_test.go

View workflow job for this annotation

GitHub Actions / lint (stable) 

Error return value is not checked (errcheck)
if got.Cmp(test.expected) != 0 {
t.Fatalf("Expected %v, got %v", test.expected, got)
}
})
}
}

func TestNewValueFromBigInt_error_syntax(t *testing.T) {
t.Parallel()

testCases := map[string]string{
"empty": "",
"invalidValue": "not a number",
}

for name, input := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()

ctx := context.Background()

var target *big.Int
_, err := newValueFromBigInt(ctx, FlagValue{Set: true, Raw: input}, reflect.ValueOf(target))
if err == nil {
t.Fatal("Expected error, got none")
}
conversionErr := InvalidConversionError{}
if !errors.As(err, &conversionErr) {
t.Fatalf("Expected clif.InvalidConversionError, got %T: %v", err, err)
}
if conversionErr.Source.Set != true || conversionErr.Source.Raw != input {

Check failure on line 69 in flag_reflect_number_big_test.go

View workflow job for this annotation

GitHub Actions / lint (stable) 

bool-literal-in-expr: omit Boolean literal in expression (revive)
t.Fatalf("Expected conversion error's source to be set with a value of %q, got set: %v value: %q", input, conversionErr.Source.Set, conversionErr.Source.Raw)
}
if !conversionErr.Target.Equal(reflect.ValueOf(target)) {
t.Fatalf("Expected conversion error's target to be %v, got %v", target, conversionErr.Target.Interface())
}
})
}
}

func TestNewValueFromBigFloat_success(t *testing.T) {
t.Parallel()

type testCase struct {
input FlagValue
expected *big.Float
target any
}
testCases := map[string]testCase{
// *big.Float
"*big.Float/0": {input: FlagValue{Set: true, Raw: "0"}, expected: big.NewFloat(0), target: big.NewFloat(0)},
"*big.Float/-1": {input: FlagValue{Set: true, Raw: "-1"}, expected: big.NewFloat(-1), target: big.NewFloat(0)},
"*big.Float/1": {input: FlagValue{Set: true, Raw: "1"}, expected: big.NewFloat(1), target: big.NewFloat(0)},
"*big.Float/max-float": {input: FlagValue{Set: true, Raw: strconv.FormatFloat(math.MaxFloat64, 'f', -1, 64)}, expected: big.NewFloat(math.MaxFloat64), target: big.NewFloat(0)},
}
for name, test := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()

ctx := context.Background()

res, err := newValueFromBigFloat(ctx, test.input, reflect.ValueOf(test.target))
if err != nil {
t.Fatalf("Unexpected error %s", err)
}
got := res.Interface().(*big.Float)

Check failure on line 104 in flag_reflect_number_big_test.go

View workflow job for this annotation

GitHub Actions / lint (stable) 

Error return value is not checked (errcheck)
if got.Cmp(test.expected) != 0 {
t.Fatalf("Expected %v, got %v", test.expected, got)
}
})
}
}

func TestNewValueFromBigFloat_error_syntax(t *testing.T) {
t.Parallel()

testCases := map[string]string{
"empty": "",
"invalidValue": "not a number",
}

for name, input := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()

ctx := context.Background()

var target *big.Float
_, err := newValueFromBigFloat(ctx, FlagValue{Set: true, Raw: input}, reflect.ValueOf(target))
if err == nil {
t.Fatal("Expected error, got none")
}
conversionErr := InvalidConversionError{}
if !errors.As(err, &conversionErr) {
t.Fatalf("Expected clif.InvalidConversionError, got %T: %v", err, err)
}
if conversionErr.Source.Set != true || conversionErr.Source.Raw != input {

Check failure on line 135 in flag_reflect_number_big_test.go

View workflow job for this annotation

GitHub Actions / lint (stable) 

bool-literal-in-expr: omit Boolean literal in expression (revive)
t.Fatalf("Expected conversion error's source to be set with a value of %q, got set: %v value: %q", input, conversionErr.Source.Set, conversionErr.Source.Raw)
}
if !conversionErr.Target.Equal(reflect.ValueOf(target)) {
t.Fatalf("Expected conversion error's target to be %v, got %v", target, conversionErr.Target.Interface())
}
})
}
}
63 changes: 63 additions & 0 deletions flag_reflect_time_test.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
package clif

import (
"context"
"reflect"
"testing"
"time"
)

func TestNewValueFromTime_success(t *testing.T) {
t.Parallel()

type testCase struct {
input FlagValue
expected time.Time
}
testCases := map[string]testCase{
"6 July 2020": {input: FlagValue{Set: true, Raw: "6 July 2020"}, expected: time.Date(2020, time.July, 6, 0, 0, 0, 0, time.UTC)},
"07/06/2020": {input: FlagValue{Set: true, Raw: "07/06/2020"}, expected: time.Date(2020, time.July, 6, 0, 0, 0, 0, time.UTC)},
"07/06/20": {input: FlagValue{Set: true, Raw: "07/06/20"}, expected: time.Date(2020, time.July, 6, 0, 0, 0, 0, time.UTC)},
}
for name, test := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()

ctx := context.Background()

var target time.Time
res, err := newValueFromTime(ctx, test.input, reflect.ValueOf(target))
if err != nil {
t.Fatalf("Unexpected error %s", err)
}
got := res.Interface().(time.Time)

Check failure on line 33 in flag_reflect_time_test.go

View workflow job for this annotation

GitHub Actions / lint (stable) 

Error return value is not checked (errcheck)
if !got.Equal(test.expected) {
t.Fatalf("Expected %v, got %v", test.expected, got)
}
})
}
}

func TestNewValueFromTime_error(t *testing.T) {
t.Parallel()

testCases := map[string]string{
"empty": "",
"mixedCase": "trUE",
"invalidValue": "yes",
}

for name, input := range testCases {
t.Run(name, func(t *testing.T) {
t.Parallel()

ctx := context.Background()

var target bool
_, err := newValueFromTime(ctx, FlagValue{Set: true, Raw: input}, reflect.ValueOf(target))
if err == nil {
t.Fatal("Expected error, got none")
}
})
}
}

0 comments on commit 6282a61

Please sign in to comment.