-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: include shortcode & block control support for v3 forms #7082
Feature: include shortcode & block control support for v3 forms #7082
Conversation
…t display options. Prior to this commit selecting a v3 form, updating its display style and then changing to a v2 form would cause the continueButtonTitle control to remain visible.
…r legacy template.
Thank you for all your help with this @alaca! I made a couple of additional changes to address inconsistencies I noticed happening, mainly in my updated inspector control.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @JoshuaHungDinh! Let's move this to QA
Description
The main purpose of this PR is to provide better compatibility to our donation form block. We have lifted many of the donation form blocks original block files/functions into our DonationForm block directory and have updated the Edit function to properly handle both v2 and v3 forms.
With this PR we have removed most of the legacy v2 block files and are pulling the v3 Edit function into our original DonationForm block. With some minor changes we were able to get v2 forms working with the selector we were using for v3 forms. Our Donation Form Block now has block support for formFormat on v3 forms - while continuing to maintain the current v2 support we have.
Some changes worth mentioning in the PR:
DonationFormBlockControls
Somethings to keep in mind:
Display styles for v3 forms
Affects
v3 forms made by shortcode and form block.
Visuals
Shortcode example:
Screen.Recording.2023-11-07.at.10.57.54.AM.mov
Donation form block example:
Screen.Recording.2023-11-07.at.8.28.24.PM.mov
Testing Instructions
Here are 3 examples of shortcodes used:
[give_form id="1672"]
[give_form id="1674" display_style="modal" continue_button_title='open modal']
[give_form id="1673" display_style="link" continue_button_title='reveal me']
Pre-review Checklist
@unreleased
tags included in DocBlocks