Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add fee to donation amount if any #7111

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix: add fee to donation amount if any #7111

merged 3 commits into from
Dec 6, 2023

Conversation

ravinderk
Copy link
Collaborator

@ravinderk ravinderk commented Nov 21, 2023

Ticket GIVE-91
Resolves https://feedback.givewp.com/bug-reports/p/paypal-donations-ignores-fee-recovery-in-v3-forms
Slack Discussion https://lw.slack.com/archives/C02R3EB3SGM/p1699891955017429

Description

I found that we were not adding a fee to the donation amount when processing transactions with PayPal Donations. I updated the logic to add a fee to the donation amount if a fee exists.

Affects

This pull request affects one-time and subscription processing.

Testing Instructions

  • The Donor should be able to process one time donation with or without fee.
  • The Donor should be able to process one subscription donation with or without fee.
  • The donation amount should match and correct in donation details and in the PayPal dashboard.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@ravinderk ravinderk self-assigned this Nov 21, 2023
@ravinderk ravinderk marked this pull request as ready for review November 21, 2023 06:23
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravinderk Sorry for the late here. Looks good to me, ready for QA!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual and automated QA tests.

@jonwaldstein jonwaldstein merged commit e799fb2 into develop Dec 6, 2023
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/GIVE-91 branch December 6, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants