Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: prevent donation form block from causing error on edit page load. #7136

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Fix: prevent donation form block from causing error on edit page load. #7136

merged 5 commits into from
Dec 13, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Dec 7, 2023 •
edited
Loading

Resolves GIVE-147

Description

  • This prevents the donation form block to render an error when v2 forms are included in the list of forms.
  • This also fixes the block inspector form selector to persist the correct form id value

Affects

The donation form block.

Visuals

N/A

Testing Instructions

  • Create a mix of v2 and v3 forms
  • Add a new page with donation form block
  • Select a v2 form
  • Refresh the page
  • You should not get an error.
  • Now select a new form using the block inspector settings and save
  • Refresh the page
  • You should see the form preview of the form you selected

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review December 7, 2023 20:10
@jonwaldstein jonwaldstein requested a review from kjohnson December 7, 2023 20:10
rickalday
rickalday approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed all manual QA tests.

@jonwaldstein jonwaldstein merged commit 1924939 into master Dec 13, 2023
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/form-block-error branch December 13, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjohnson kjohnson kjohnson approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonwaldstein @rickalday @kjohnson