Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: remove default display argument on [give_form] to support legacy form meta #7144

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Hotfix: remove default display argument on [give_form] to support legacy form meta #7144

merged 2 commits into from
Dec 13, 2023

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Dec 13, 2023 •
edited by jonwaldstein
Loading

Resolves #7132, GIVE-145

Related: #7134

Description

This PR removes the default argument supplied to the give form shortcode. Legacy templates rely on this value being empty. When no value is present the Legacy template can use the default values stored in the form meta for display.

Affects

Donation Form shortcode/block

Visuals

Screen.Recording.2023-12-13.at.12.55.15.PM.mov
Screen.Recording.2023-12-13.at.4.08.18.PM.mov

Testing Instructions

  • Create a v2 Legacy template form
  • Edit the form & select a form display option
  • Create a shortcode and do not use the display style attribute in the shortcode.
  • Example: [give_form id=100]
  • View page verify the shortcode displays the form with the proper display selected from the edit page.
  • Edit the shortcode -> add a display style -> verify new display works on page.
  • Repeat for each legacy template display style.

Pre-review Checklist

  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

@JoshuaHungDinh
fix: remove form shortcode default arg for display. legacy template r…
45ecbc9 
…equires an empty value here so that it may default to form meta display options.
@JoshuaHungDinh JoshuaHungDinh changed the title Hotfix: remove default display option on [give_form] [GIVE-145] Hotfix: remove default display option on [give_form] - [GIVE-145] Dec 13, 2023
@JoshuaHungDinh JoshuaHungDinh changed the title Hotfix: remove default display option on [give_form] - [GIVE-145] Hotfix: remove default display option on [give_form] Dec 13, 2023
@JoshuaHungDinh JoshuaHungDinh changed the title Hotfix: remove default display option on [give_form] Hotfix: remove default display option on [give_form] to support legacy form meta Dec 13, 2023
@JoshuaHungDinh JoshuaHungDinh changed the title Hotfix: remove default display option on [give_form] to support legacy form meta Hotfix: remove default display argument on [give_form] to support legacy form meta Dec 13, 2023
@jonwaldstein jonwaldstein self-requested a review December 13, 2023 14:35
@alexwcoleman alexwcoleman self-requested a review December 13, 2023 15:39
@jonwaldstein jonwaldstein merged commit b236e5f into master Dec 13, 2023
20 checks passed
@jonwaldstein jonwaldstein deleted the hotfix/legacy-shortcode-display-default-meta-args-GIVE-145 branch December 13, 2023 17:30
@jonwaldstein jonwaldstein mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

@alexwcoleman alexwcoleman alexwcoleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaHungDinh @alexwcoleman @jonwaldstein