Enhancement: better input validation #7668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaubersilva
force-pushed
the
enhancement/better-input-validation-GIVE-2073
branch
from
f00457c to
999058d
Compare
jonwaldstein
requested changes
Jan 7, 2025
|
@jonwaldstein This is ready for re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2073
Description
This PR refactors the
containsSerializedDataRegex()method to ensure it will work with strings containing special characters and encoded strings. It also adds a new sample string to the unit tests to ensure everything is working as expected.Pre-review Checklist
@unreleasedtags included in DocBlocks