Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel Deprecation #207

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Bazel Deprecation #207

merged 2 commits into from
Oct 22, 2019

Conversation

Dig-Doug
Copy link
Contributor

Follow up to this discussion.

This change does the following:

  • Removes the bulk of bazel related code
  • Leaves a empty implementation of the rules that prints a deprecation warning, in case someone tries to update their version without looking at the README
  • Updates the README to point to the new implementation.

After this PR, the only remaining pieces of bazel related code are the WORKSPACE, the BUILD, and the defs.bzl files. They can be cleaned up sometime in the future.

- Adds a deprecation warning to the exported rules and points to the migration docs
@Dig-Doug
Copy link
Contributor Author

Fixes #171.

@jonny-improbable jonny-improbable merged commit dc70c35 into improbable-eng:master Oct 22, 2019
@jonny-improbable
Copy link
Contributor

Lovely stuff, thanks for your stewardship @Dig-Doug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants