-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added updated check for docs in Makefile #291
base: main
Are you sure you want to change the base?
Conversation
@kairoaraujo PTAL !! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 82.40% 1.64% -80.76%
==========================================
Files 10 120 +110
Lines 358 28856 +28498
==========================================
+ Hits 295 476 +181
- Misses 43 28323 +28280
- Partials 20 57 +37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DarikshaAnsari,
Thank you for your PR. 🎉
I think we should run the update_docs
and the check_docs
.
Note: stat -c
is not a standard in all OS. Maybe we could check it using diff
? 🤔
Nit: I suggest also having it to the .github/workflows
for automatic checks. We can do it in another PR as well.
@kairoaraujo I have changed all the require changes you've mentioned also I have added checks in .github/workflow . |
@kairoaraujo PTAL !! |
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: John Kjell <[email protected]>
Fixes #180
Acceptance Criteria Met