Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step analyze fix #257

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Step analyze fix #257

merged 2 commits into from
Jun 11, 2024

Conversation

jkjell
Copy link
Member

@jkjell jkjell commented May 23, 2024

If any evidence exists that causes a step evaluation to fail, the entire policy will fail, even if there's passing evidence at another search depth. Also, results from the verifyArtifacts function are carrying forward passed results, even if the artifact comparison doesn't match.

Copy link
Contributor

@kriscoleman kriscoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

@ChaosInTheCRD
Copy link
Collaborator

Sorry for leaving this for so long

@jkjell jkjell merged commit 946f98e into main Jun 11, 2024
16 checks passed
@jkjell jkjell deleted the step-analyze-fix branch June 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants