Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat:vault signer #276

Merged
merged 8 commits into from
Aug 10, 2023
Merged

Feat:vault signer #276

merged 8 commits into from
Aug 10, 2023

Conversation

mikhailswift
Copy link
Member

@mikhailswift mikhailswift commented Aug 8, 2023 •
edited
Loading

  • Uses the signer registry to create CLI flags *note that this will cause some existing flags to change*
  • Adds support for vault's pki secret engine

@mikhailswift mikhailswift force-pushed the feat/vault-signer branch 2 times, most recently from 68113a9 to 3301d89 Compare August 9, 2023 18:16
jkjell
jkjell reviewed Aug 9, 2023
View reviewed changes
cmd/keyloader.go Outdated Show resolved Hide resolved
docs/witness_run.md Show resolved Hide resolved
@mikhailswift
feat: use signer registry to setup signers for CLI flags
4d9b407
@mikhailswift
docs: regenerate docs for new cli flags
e58a2ec
@mikhailswift
refactor: create helper function to add options from registries
5a21458
@mikhailswift
docs: regenerate docs for new cli flags
d6d57af
@mikhailswift
fix: re-enable verify tests
4879b67 
As part of the signer registry refactor I commented these tests out to
work on some other tests. Turns out I forgot to uncomment and fix these
before merging the refactor... Ooops.
@mikhailswift
fix: use the pflag.FlagSet.Set function to set values from config files
c067073 
Previously we were calling .Set on the flag's value directly. However,
this caused the flagset to be unaware that a flag's value had been
changed. This hadn't affected us before, but with the signer registry
changes we are determing which signers to create based on which flags
were set.
@mikhailswift
fix: update changed signer flags in tests
8c50d47
@mikhailswift mikhailswift merged commit aa35c1f into main Aug 10, 2023
9 checks passed
@mikhailswift mikhailswift deleted the feat/vault-signer branch August 10, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colek42 colek42 colek42 left review comments

@jkjell jkjell jkjell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikhailswift @jkjell @colek42