Merge pull request #67 from inaka/v2.0.1

V2.0.1

CHANGELOG.md

@@ -6,14 +6,20 @@ All notable changes to this project will be documented in this file. `Jayme` a
 
 ### 2.x Releases
 
-- `2.0.x` Releases - [2.0.0](#200)
+- `2.0.x` Releases - [2.0.0](#200) | [2.0.1](#201)
 
 ### 1.x Releases
 
 - `1.0.x` Releases - [1.0.1](#101) | [1.0.2](#102) | [1.0.3](#103) | [1.0.4](#104) 
 
 ---
 
+## 2.0.1
+
+- `create(...)` function in `CRUDRepository` no longer attaches the `:id` parameter in its `POST` URL. (Issue [#63](https://github.com/inaka/Jayme/issues/63))
+- Results from repositories are now returned on the main thread. (Issue [#55](https://github.com/inaka/Jayme/issues/55))
+- Added `PATCH` verb in `HTTPMethodName` enumeration. (Issue [#57](https://github.com/inaka/Jayme/issues/57))
+
 ## 2.0.0
 
 #### Repository related changes

Documentation/Jayme 2.0 Migration Guide.md

@@ -44,6 +44,9 @@ They are listed below:
     - `self.parseDataAsDictionary(…)` → `DataParser().dictionaryFromData(…)`
     - `self.parseEntitiesFromArray(…)` → `EntityParser().entitiesFromDictionaries(…)`
     - `self.parseEntityFromDictionary(…)` → `EntityParser().entityFromDictionary(…)`
+- Results from Repositories using `NSURLBackend` (ex `ServerBackend`) are now returned on the main thread, instead of on a background thread.
+  - This will not break your existing code, but it's strongly recommended that you remove any possible `dispatch_async(dispatch_get_main_queue()) { ... }` call that you could have performed within your ViewControllers when getting results back from any repository. These calls are unnecessary now.
+
 
 ---
 

Example/UserDetailViewController.swift

@@ -44,9 +44,7 @@ class UserDetailViewController: UIViewController {
             switch result {
             case .Success(let posts):
                 self.posts = posts
-                dispatch_async(dispatch_get_main_queue()) {
-                    self.tableView.reloadData()
-                }
+                self.tableView.reloadData()
             case .Failure(let error):
                 self.showAlertControllerForError(error)
             }

Example/UsersViewController.swift

@@ -46,9 +46,7 @@ class UsersViewController: UIViewController {
             switch result {
             case .Success(let users):
                 self.users = users
-                dispatch_async(dispatch_get_main_queue()) {
-                    self.tableView.reloadData()
-                }
+                self.tableView.reloadData()
             case .Failure(let error):
                 self.showAlertControllerForError(error)
             }

Jayme.podspec

@@ -1,7 +1,7 @@
 
 Pod::Spec.new do |s|
   s.name         = "Jayme"
-  s.version      = "2.0.0"
+  s.version      = "2.0.1"
   s.summary      = "Abstraction layer that eases RESTful interconnections in Swift"
   s.description  = <<-DESC
                    What's the best place to put your entities business logic code? What's the best place to put your networking code? Jayme answers those two existencial questions by defining a straightforward and extendable architecture based on Repositories and Backends. It provides a neat API to deal with REST communication, leaving your ViewControllers out of that business by abstracting all that logic, thereby allowing them to focus on what they should do rather than on how they should connect to services.

Jayme/CRUDRepository.swift

@@ -51,7 +51,7 @@ public extension CRUDRepository {
 
     /// Creates the entity in the repository. Returns a `Future` with the created entity or a `JaymeError`
     public func create(entity: EntityType) -> Future<EntityType, JaymeError> {
-        let path = self.pathForID(entity.id)
+        let path = self.name
         return self.backend.futureForPath(path, method: .POST, parameters: entity.dictionaryValue)
             .andThen { DataParser().dictionaryFromData($0.0) }
             .andThen { EntityParser().entityFromDictionary($0) }

Jayme/HTTPHeader.swift

@@ -27,4 +27,9 @@ import Foundation
 public struct HTTPHeader {
     public let field: String
     public let value: String
+
+    public init(field: String, value: String) {
+        self.field = field
+        self.value = value
+    }
 }

Jayme/HTTPMethodName.swift

@@ -25,5 +25,5 @@ import Foundation
 
 /// Discrete enumeration of possible HTTP methods
 public enum HTTPMethodName: String {
-    case POST, GET, PUT, DELETE
+    case POST, GET, PUT, PATCH, DELETE
 }

Jayme/NSURLSessionBackend.swift

@@ -52,13 +52,15 @@ public class NSURLSessionBackend: Backend {
             let task = self.session.dataTaskWithRequest(request) { data, response, error in
                 let response: FullHTTPResponse = (data, response, error)
                 let result = self.responseParser.parseResponse(response)
-                switch result {
-                case .Success(let maybeData, let pageInfo):
-                    Logger.sharedLogger.log("Jayme: Response #\(requestNumber) | Success")
-                    completion(.Success(maybeData, pageInfo))
-                case .Failure(let error):
-                    Logger.sharedLogger.log("Jayme: Response #\(requestNumber) | Failure, error: \(error)")
-                    completion(.Failure(error))
+                dispatch_async(dispatch_get_main_queue()) {
+                    switch result {
+                    case .Success(let maybeData, let pageInfo):
+                        Logger.sharedLogger.log("Jayme: Response #\(requestNumber) | Success")
+                        completion(.Success(maybeData, pageInfo))
+                    case .Failure(let error):
+                        Logger.sharedLogger.log("Jayme: Response #\(requestNumber) | Failure, error: \(error)")
+                        completion(.Failure(error))
+                    }
                 }
             }
             task.resume()

Jayme/NSURLSessionBackendConfiguration.swift

@@ -26,12 +26,17 @@ import Foundation
 /// Structure used for holding relevant information that NSURLSessionBackend needs in order to work.
 public struct NSURLSessionBackendConfiguration {
 
-    let basePath: Path
-    let httpHeaders: [HTTPHeader]
+    public let basePath: Path
+    public let httpHeaders: [HTTPHeader]
 
     public static var defaultConfiguration = NSURLSessionBackendConfiguration(basePath: "http://localhost:8080",
                                                                  httpHeaders: NSURLSessionBackendConfiguration.defaultHTTPHeaders)
 
+    public init(basePath: Path, httpHeaders: [HTTPHeader]) {
+        self.basePath = basePath
+        self.httpHeaders = httpHeaders
+    }
+
     // MARK: - Private
 
     private static var defaultHTTPHeaders = [HTTPHeader(field: "Accept", value: "application/json"),

JaymeTests/CRUDRepositoryTests.swift

@@ -61,7 +61,7 @@ extension CRUDRepositoryTests {
     func testCreateCall() {
         let document = TestDocument(id: "123", name: "a")
         self.repository.create(document)
-        XCTAssertEqual(self.backend.path, "documents/123")
+        XCTAssertEqual(self.backend.path, "documents")
         XCTAssertEqual(self.backend.method, .POST)
         guard let
             id = self.backend.parameters?["id"] as? String,