closes #223

inaturalist · Nov 23, 2020 · 821800d · 821800d
1 parent fbb3dd9
commit 821800d
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/models/observation_query_builder.js b/lib/models/observation_query_builder.js
@@ -943,19 +943,17 @@ ObservationQueryBuilder.reqToElasticQueryComponents = async req => {
   }
 
   _.each( ["geoprivacy", "taxon_geoprivacy"], geoprivacyField => {
-    if ( params[geoprivacyField] === "open" ) {
-      inverseFilters.push( { exists: { field: geoprivacyField } } );
-    } else if ( params[geoprivacyField] === "obscured_private" ) {
+    if ( params[geoprivacyField] === "obscured_private" ) {
       searchFilters.push( esClient.termFilter( geoprivacyField, ["obscured", "private"] ) );
     } else if ( params[geoprivacyField] && params[geoprivacyField] !== "any" ) {
       const geoprivacyFieldFilter = esClient.termFilter( geoprivacyField, params[geoprivacyField] );
       if ( geoprivacyFieldFilter.terms[geoprivacyField].indexOf( "open" ) < 0 ) {
         searchFilters.push( geoprivacyFieldFilter );
       } else {
-        // Since "open" just means the field isn't there, we need a should to do
-        // something like "geoprivacy IS NULL OR geoprivacy IN (x,y,z)"
+        // Since "open" means the field isn't there or is open, we need to do
+        // something like "geoprivacy IS NULL OR geoprivacy is open"
         geoprivacyFieldFilter.terms[geoprivacyField] = _.filter(
-          geoprivacyFieldFilter.terms[geoprivacyField], g => g !== "open"
+          geoprivacyFieldFilter.terms[geoprivacyField], g => g == "open"
         );
         searchFilters.push( {
           bool: {