Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript lecture #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

arbazkhan56
Copy link

@arbazkhan56 arbazkhan56 commented Dec 19, 2020

What is the change?

Adding the javascript Tutorials

Related issue?

Issue: #3

Files edited?

  1. app.js
  2. index.ejs
  3. list.js

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes like this ([x]).

  • I've checked there aren't other open Pull Requests for the same update/change?
  • I've made corresponding changes to the documentation?
  • My submission doesn't break any existing feature.
  • I've tested this code locally before submission?

Screenshots:

not required

@littleironical
Copy link
Member

@arbazkhan56 Commit changes in develop branch, not in master branch

Copy link
Member

@Nishant2907 Nishant2907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You have added youtube links to the list, but what we want here is the embedded links. So kindly look into that.
  2. Another thing is that the changes you did in the app.js and index.ejs. They are not working as it should work.
  3. Still, the previous links and list is being shown in all the subjects. So look after them too.

@littleironical
Copy link
Member

@arbazkhan56 Don't delete those youtube links, those are useful in hashcode_app if you don't know flutter then just put a text in the given link and I'll guide you in that.

Copy link
Author

@arbazkhan56 arbazkhan56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have solved the issue in these files. It will run easily.

@arbazkhan56
Copy link
Author

I have never worked with flutter Before.

Copy link
Member

@Nishant2907 Nishant2907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the list.js you have added the youtube video links. Replace them with the youtube embedded video links. Rest seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants