-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript lecture #7
base: master
Are you sure you want to change the base?
Conversation
@arbazkhan56 Commit changes in develop branch, not in master branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You have added youtube links to the list, but what we want here is the embedded links. So kindly look into that.
- Another thing is that the changes you did in the
app.js
andindex.ejs
. They are not working as it should work. - Still, the previous links and list is being shown in all the subjects. So look after them too.
@arbazkhan56 Don't delete those youtube links, those are useful in hashcode_app if you don't know flutter then just put a text in the given link and I'll guide you in that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have solved the issue in these files. It will run easily.
I have never worked with flutter Before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the list.js
you have added the youtube video links. Replace them with the youtube embedded video links. Rest seems fine to me.
What is the change?
Adding the javascript Tutorials
Related issue?
Issue: #3
Files edited?
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes like this (
[x]
).Screenshots:
not required