-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and 1.0-rc.1
#196
Comments
I would both ignore AND deprecate |
After discussion with @peterdesmet, we will:
The factor value to use for
|
read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and 0.6read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and ~0.6~ 1.0-rc.1
read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and ~0.6~ 1.0-rc.1read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and 1.0-rc.1 (not 0.6)
@peterdesmet: about
We provided a patch to read not-in-schema terms |
read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and 1.0-rc.1 (not 0.6)read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and 1.0-rc.1
Decided to still leave |
Decided with @peterdesmet to map "new" field |
Notice that |
Notice also that new new format has 4 bounding box related columns:
I will not remove nor rename them. List terms in original comment of @peterdesmet updated |
If you retain them, will that effect tests? |
The only affected test was the one where I check the column names. I run all package functions locally without any issue. Notice that I didn't write new tests for each test. I wrote "only" a lot of new tests for checking that the output of |
If the bbox columns are the only ones we add, I would ignore them at this stage as they are not part of 0.1.6. Doesn’t feel right to make an exception for just these. |
Decided with @peterdesmet to remove bounding box related columns as they could be confusing for the user at this stage. |
Agreed with @peterdesmet: do not add |
I see in https://github.com/tdwg/camtrap-dp/blob/ef261578d956e1d3ece78ead760e0bd2d4df81c8/camtrap-dp-profile.json#L231C16-L245 that |
Contrarely to |
Solved by #223 |
For camtraptor v0.20 we envision
read_camtrap_dp()
to be able to read legacy Agouti exports (Camtrap DP 0.1.6) and new Agouti exports (Camtrap DP 1.0-rc.1) without affecting the other functions (i.e. non-breaking change).To do this,
read_camtrap_dp()
should:package$profile
media
flag (debatable): decided to not do it in v0.20 (see Updateread_camtrap_dp()
so it can read Camtrap DP 0.1.6 and 1.0-rc.1 #196 (comment))The required changes are listed below.
profile
author
/maintainer
are deprecated in 1.0-rc.1, some new roles are added. Ok to leave as is.observationLevel
in 1.0-rc.1. Convert to old name.sources
and assigntitle
asplatform$title
rightsHolder
and assigntitle
asrightsHolder
project$references
, but was never populated for Agouti). Ok to leave in.$data$deployments
eventStart
eventEnd
cameraDelay
baitUse
deploymentTags
deploymentComments
$data$media
deprecated, leave empty? Not sure if this will break things.created by joiningmedia
andobservations
ondeploymentID
andtimestamp
betweeneventStart
andeventEnd
as proposed in Single observation table tdwg/camtrap-dp#314favorite
mediaComments
$data$observations
observationLevel = event
eventID
eventStart
cameraSetupType
behavior
classificationProbability
observationComments
individualSpeed
read_camtrap_dp()
so it can read Camtrap DP 0.1.6 and 1.0-rc.1 #196 (comment))radius
)The text was updated successfully, but these errors were encountered: