-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read camtrap dp v1.0 rc.1 #223
Conversation
Only interval related indo needs changes
Retrieve values from tags, comments otherwise. If not possible: set FALSE to "none" and TRUE to "other".
And check that's supported
This is an application of #216
Based on #196 (comment)
Co-Authored-By: Peter Desmet <[email protected]>
About |
About |
@peterdesmet: about your suggestion for the README, see a91a02a. |
Co-Authored-By: Peter Desmet <[email protected]>
Co-Authored-By: Peter Desmet <[email protected]>
Co-Authored-By: Peter Desmet <[email protected]>
Co-Authored-By: Peter Desmet <[email protected]>
About message returning ignored terms, @peterdesmet, I have question about messaging these two terms: |
I would not add any specific lines about what is and hasn't been ignored. |
Co-Authored-By: Peter Desmet <[email protected]>
Co-Authored-By: Peter Desmet <[email protected]>
Co-Authored-By: Pieter Huybrechts <[email protected]>
Co-Authored-By: Pieter Huybrechts <[email protected]>
Thanks, now I understand perfectly what you meant with |
Especially taking care of improving check_package() in check_package.R based on the work done in #223
This PR allows users to read camtrap data packages written using v1.0-rc.1 without affecting the other functions (i.e. non-breaking change). See issue discussion in #196. While working on this PR, I fixed two other minor issues spotted while helping @jimcasaer: see #218 and #217.
Notice that
.observations
data.frame could de different based on the Camtrap DP version.media
anddeployments
are the same.Minor issue: by writing the converting functions I introduced some
NOTES
while running package checks:They don't seem easy to remove. I will check them later, but I think we can start the review process.
Fixes #217