Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

259 datapkg argument #271

Merged
merged 27 commits into from
Sep 5, 2023
Merged

259 datapkg argument #271

merged 27 commits into from
Sep 5, 2023

Conversation

PietrH
Copy link
Member

@PietrH PietrH commented Sep 4, 2023

Fixes #259

Major TODO:

  • Entirely remove datapkg as a deprecated alternative argument for package in all functions where it is used
  • Remove function_name from check_package(), see this comment Read camtrap dp v1.0 rc.1 #223 (comment)

Steps

Remove datapkg argument from:

  • check_package()
  • check_species()
  • get_cam_op()
  • get_custom_effort()
  • get_effort()
  • get_n_individuals()
  • get_n_obs()
  • get_n_species()
  • get_rai()
  • get_record_table()
  • get_scientific_name()
  • get_species()
  • map_dep()
  • get_dep_no_obs() (zzz.R)

And tests for:

  • check_package()
  • get_cam_op()
  • get_custom_effort()
  • get_effort()
  • get_n_individuals()
  • get_n_obs()
  • get_n_species()
  • get_rai_individuals()
  • get_rai()
  • get_record_table()
  • get_scientific_name()
  • get_species()
  • map_dep()

Also adapt check_package() call to remove function_name use (used for lifecyle warning) in:

  • check_species()
  • get_custom_effort()
  • get_effort()
  • get_n_individuals()
  • get_n_obs()
  • get_n_species()
  • get_rai()
  • get_rai_individuals() (get_rai.R)
  • get_record_table()
  • get_scientific_name()
  • get_species()
  • map_dep()
  • get_dep_no_obs() (zzz.R)

Documentation

  • remove any mention to datapkg in roxygen documentation
  • run devtools::document()

@PietrH PietrH added the v1.0 label Sep 4, 2023
@PietrH PietrH self-assigned this Sep 4, 2023
@PietrH PietrH linked an issue Sep 4, 2023 that may be closed by this pull request
2 tasks
@damianooldoni damianooldoni removed the v1.0 label Sep 4, 2023
@PietrH PietrH added this to the v1.0 milestone Sep 4, 2023
@PietrH PietrH marked this pull request as ready for review September 4, 2023 12:01
@PietrH PietrH requested review from damianooldoni and peterdesmet and removed request for damianooldoni September 4, 2023 12:01
This was referenced Sep 4, 2023
Copy link
Member

@damianooldoni damianooldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@damianooldoni
Copy link
Member

Note: after pulling updated v1.0 in this branch, add note in news.md.

@PietrH PietrH merged commit eb31eb4 into v1.0 Sep 5, 2023
8 checks passed
@PietrH PietrH deleted the 259-datapkg-argument branch September 5, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated datapkg argument from functions
2 participants