Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check about non-empty values in column defined by station_col #217

Closed
damianooldoni opened this issue Jun 12, 2023 · 0 comments · Fixed by #223
Closed

Add check about non-empty values in column defined by station_col #217

damianooldoni opened this issue Jun 12, 2023 · 0 comments · Fixed by #223
Assignees
@damianooldoni
Milestone
v0.20

Comments

@damianooldoni
Copy link
Member

No NA are allowed in column station_col of get_cam_op(). Otherwise an error occurs in the middle of the function. A check must be added at the very begin of the function.
@damianooldoni damianooldoni self-assigned this Jun 12, 2023
damianooldoni added a commit that referenced this issue Jun 12, 2023
@damianooldoni
Fix #217
88e60d7 
Add assertion and test
@damianooldoni damianooldoni added this to the v0.20 milestone Jun 12, 2023
@damianooldoni damianooldoni mentioned this issue Jul 17, 2023
Merged
@PietrH PietrH linked a pull request Jul 20, 2023 that will close this issue
Add check about non empty values in column station_col in get_cam_op() #258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damianooldoni damianooldoni

Labels
None yet
Projects
None yet
Milestone
v0.20
1 participant
@damianooldoni