Use filter functions/remove args from functions

[damianooldoni]

This PR solves few issues at the same time as it was difficult to disentangle them.

• Deprecate map_dep(), create map_deployments() (fix Rename map_dep() to map_deployments() #231). Deprecate also the args sex and life_stage of map_dep(). Why deprecate args of a deprecated function? Because the proposed new solutions are different: the deprecated arguments are not replaced by some args in map_deployments(): the user need to filter via filter_observations().
• Use the reexported filtering functionality filter_observations() in (deprecated) map_dep(sex, life_stage). Also update all examples where we show how to filter by sex and life stage via filter_observations().
• Make predicate functions defunct (fix Remove predicate functions - use filter_deployments() #316): they were just abruptly removed in PR Remove predicate functions #321.
• Deprecate get_n_species, create n_species() (fix Rename get_n_species() to n_species() #243).
• Deprecate get_cam_op(), create camtrapR_cameraOperation() (fix Rename get_cam_op() to camtrapR_cameraOperation() #239).
• Deprecate get_record_table(), create camtrapR_recordTable() (fix Rename get_record_table() to camtrapR_recordTable() #240).
• Update related tests file: new filenames, new function names, new tests for deprecations.
• Reexport the pipe from dplyr, as we did in camtrapdp (fix Export pipe %>% #330)
• Remove round_coordinates() (fix remove round_coordinates() and write_dwc() #327)
• Use purrr::pluck() where needed (fix Use purrr::pluck() instead of $ #326)
• Update, improve and compile documentation (devtools::document())

[damianooldoni]

Thanks @sannegovaert!
Yes, many tests still fail, but it's normal. We decided to do the update to v1 step by step and it's quite impossible to adapt all tests at this stage. I changed only the tests which were relevant for this PR. Other tests will be updated while working on the core of the related functions, e.g. see #332.

I will screen and reply to your comments, one by one, of course.

[damianooldoni]

Using example_dataset() is not the wished behavior.

See get_scientific_name() in main:

get_scientific_name <- function(package = NULL,
                                vernacular_name,
                                datapkg = lifecycle::deprecated()) {
check_package(package, datapkg, "get_scientific_name")
  if (is.null(package) & !is.name(datapkg)) {
    package <- datapkg
  }

The idea here was to use datapkg (deprecated) if package was not given.

Still, thanks to you I see that I have to remove this if () statement 👍
Moreover, this function will disappear in one of the next PRs. See #235.
Done in a7193bf

[sannegovaert]

Thanks for addressing everything, Damiano!
I just replaced another lifecycle_warning_deprecated.
All seems good to go now!

[damianooldoni]

Hi @sannegovaert, thanks for checking again. Can you officially approve the PR? Thanks.