-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DHMV API #12
Open
falkmielke
wants to merge
11
commits into
next-version
Choose a base branch
from
dhmv_api
base: next-version
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add DHMV API #12
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5cb2eda
dhmv: adjust/extend `get_coverage_wcs()`*
falkmielke 074248c
dhmv: vignette
falkmielke d9b2741
dhmv: adjust/extend `get_coverage_wcs()`*
falkmielke a1014bc
dhmv: vignette
falkmielke ccfb778
DHMV API: rebase, mht adjustment, vignette*
falkmielke 9b01071
DHMV API: rebase led to merge conflicts
falkmielke 3377221
dhmv api: update with `next-version`
falkmielke 72a83d2
DHMV API: news entry + a bug
falkmielke 30bf8ea
DHMV API: author @falkmielke
falkmielke 98256b4
DHMV API: checklist spell checks and linting
falkmielke dcb3e83
DHMV API: checklist adjustments
falkmielke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is crucial that the correct EPSG code is passed here. This is the CRS that is used in the WCS to store the raster data. I noticed that using the default EPSG:4258 with DHMV resulted in raster image that was shifted compared to the corresponding wcs = "dtm" alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Yet shift alone does not indicate which one is wrong.
And actually, I don't understand why we should make the "input" crs explicit. Shouldn't the web API know by itself what crs is used, return it, and only upon user request apply transformation to an
output_crs
?