Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch mht #15

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Patch mht #15

merged 8 commits into from
Oct 21, 2024

Conversation

hansvancalster
Copy link
Collaborator

Should fix a problem with unpack_mht() to find the correct starting line of embedded geoTIFF

@falkmielke
Copy link

Thank you for fixing the URLs and the mht extraction!

  • I did check the vignette, and all seems to work (except that one WFS block with the sf point intersect).
  • I did not check the mht extraction yet (no test query at hand), but the limited changes seem plausible. I suppose it works as you intended and tested, will try v2.0.1 again on DHMV, and get back if there are issues.

I also took the liberty of adding more explanatory text to the WFS/WCS vignette. I felt it was lacking, and didn't want to leave this work to you without at least a suggestion. Thank you for proofreading and feel free to adjust.

Copy link

@falkmielke falkmielke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments and additions. Thank you for the adjustments!

@hansvancalster hansvancalster merged commit 2b31494 into next-version Oct 21, 2024
3 checks passed
@hansvancalster hansvancalster deleted the patch-mht branch October 21, 2024 15:22
@hansvancalster hansvancalster mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants