Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: structural cleanup, link and navigation styles, project page #72

Merged
merged 16 commits into from
Jan 17, 2025

Conversation

greatislander
Copy link
Member

No description provided.

Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>

# Conflicts:
#	src/_includes/partials/global/footer.njk
#	src/assets/styles/base/_base.css
#	src/assets/styles/global/footer.css
Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2025

Deploying inclusive-standards with  Cloudflare Pages  Cloudflare Pages

Latest commit: c545dbb
Status: ✅  Deploy successful!
Preview URL: https://39514770.inclusive-standards.pages.dev
Branch Preview URL: https://feat-links-and-navigation.inclusive-standards.pages.dev

View logs

@greatislander greatislander marked this pull request as ready for review January 17, 2025 16:42
@greatislander greatislander requested a review from chosww January 17, 2025 16:42
@greatislander greatislander self-assigned this Jan 17, 2025
@greatislander greatislander added the enhancement New feature or request label Jan 17, 2025
@greatislander greatislander added this to the v1.0 milestone Jan 17, 2025
Copy link
Contributor

@chosww chosww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues caused by new UIO update? (I assume), and that is transparent border colour without fallback breaks the card components in UIO contrast themes.

src/assets/styles/global/_footer.css Show resolved Hide resolved
@chosww
Copy link
Contributor

chosww commented Jan 17, 2025

There are some issues caused by new UIO update? (I assume), and that is transparent border colour without fallback breaks the card components in UIO contrast themes.

I have a fix for the issues, I can push a commit if you want, but they are:

Card component:

.card:has(a:focus) {
    border: 0.1875rem solid var(--fl-fgColor, transparent);
}

.card__content {
    border: 0.1875rem solid var(--fl-fgColor, transparent);
}

ProjectPanel component:

.project-panel:has(a:focus) {
    border: 0.1875rem solid var(--fl-fgColor, transparent);
}

.project-panel__content {
    border: 0.1875rem solid var(--fl-fgColor, transparent);
}

@greatislander
Copy link
Member Author

Please go ahead and push that fix, @chosww !

@chosww
Copy link
Contributor

chosww commented Jan 17, 2025

Please go ahead and push that fix, @chosww !

Done! I added hover style for the svg in the footer as well.

@chosww chosww self-requested a review January 17, 2025 19:45
@greatislander greatislander merged commit 628a9aa into dev Jan 17, 2025
2 checks passed
@greatislander greatislander deleted the feat/links-and-navigation branch January 17, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links: hover, focus and active states Mobile navigation: hover, focus and active states
2 participants