Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waitForWorkflow API for workflow with multiple thread results #230

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

longquanzheng
Copy link
Contributor

It's broken when workflow has multiple different completion results.

@longquanzheng longquanzheng requested a review from lanespade July 19, 2024 20:38
@longquanzheng longquanzheng changed the title Fix waitForWorkflow API Fix waitForWorkflow API for workflow with multiple thread results Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.33%. Comparing base (71bc52d) to head (9b1f23b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #230      +/-   ##
============================================
- Coverage     71.37%   71.33%   -0.05%     
  Complexity      416      416              
============================================
  Files            64       64              
  Lines          1743     1744       +1     
  Branches        161      161              
============================================
  Hits           1244     1244              
- Misses          413      414       +1     
  Partials         86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lanespade lanespade self-assigned this Jul 19, 2024
Copy link
Contributor

@lanespade lanespade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@longquanzheng longquanzheng merged commit 1f9f8be into main Jul 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants