Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IWF-107: Updating iwf-idl submodule to reflect changes for IdReusePol… #243

Merged
merged 3 commits into from
Sep 26, 2024
Merged

IWF-107: Updating iwf-idl submodule to reflect changes for IdReusePol… #243

merged 3 commits into from
Sep 26, 2024

Conversation

stevo89519
Copy link
Contributor

…icy typo changes

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing

Related Issue

Closes #204

@stevo89519
Copy link
Contributor Author

@longquanzheng I wasn't able to find any references to ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY in this repo except for within the iwf-idl submodule, so I just updated it to reflect the changes made previously.
Did I miss something?

@longquanzheng
Copy link
Contributor

longquanzheng commented Sep 25, 2024 •
edited
Loading

@longquanzheng I wasn't able to find any references to ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY in this repo except for within the iwf-idl submodule, so I just updated it to reflect the changes made previously. Did I miss something?

I think that’s right. Because we don’t have any tests or code directly referencing to it. We allow client to pass the policy in workflow options.
But would encourage add a new test so that you will understand it better ☺️

@stevo89519
Copy link
Contributor Author

But would encourage add a new test so that you will understand it better ☺️

@longquanzheng Test added. Please re-review.

longquanzheng
longquanzheng reviewed Sep 26, 2024
View reviewed changes
src/test/java/io/iworkflow/integ/basic/AbnormalExitState1.java
import io.iworkflow.core.communication.Communication;
import io.iworkflow.core.persistence.Persistence;

public class AbnormalExitState1 implements WorkflowState<Integer> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it's better to set retry policy to let the workflow fail immediate after one attempt. So that the test can complete earlier: https://github.com/indeedeng/iwf-java-sdk/blob/main/src/test/java/io/iworkflow/integ/stateapifail/StateFailBasic.java#L43

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added it.

@stevo89519 stevo89519 merged commit 4c9025f into main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longquanzheng longquanzheng longquanzheng approved these changes

@samuel27m samuel27m Awaiting requested review from samuel27m

@lwolczynski lwolczynski Awaiting requested review from lwolczynski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix typo IdReusePolicy of ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY
2 participants
@stevo89519 @longquanzheng