Bug: To accept score as final when admin of both playing teams submit a score #245

Joe2k · 2023-12-14T09:15:09Z

No description provided.

Joe2k · 2023-12-27T18:31:40Z

Change Log

Fix the bug where if a admin of both teams in a match enter a score we consider it final and submit it
If a user is admin of both teams of a match we show both teams spirit scoring form in the same modal to enter
Scroll button fix where old js to fetch scroll height was not working correctly hence button is not visible
Added ability to enter spirit scores including self-scores from the tournament manager

Joe2k · 2024-01-13T18:26:15Z

@SibiAkkash Can you review this next? Will merge once reviewed

server/api.py

frontend/src/components/TournamentMatch.js

submit-score: Accept final score submitted by multi team admin

12e2015

Joe2k requested review from punchagan and SibiAkkash December 14, 2023 09:15

Joe2k self-assigned this Dec 14, 2023

Joe2k force-pushed the admin-cleanup branch from ac8cb71 to 2fb225b Compare December 20, 2023 17:29

SibiAkkash requested changes Jan 15, 2024

View reviewed changes

server/api.py Show resolved Hide resolved

frontend/src/components/TournamentMatch.js Outdated Show resolved Hide resolved

Joe2k added 6 commits January 18, 2024 23:45

submit-spirit-score: Add team_id to api

4367e78

submit-spirit-score: Add team name under self score

0f7a6fa

submit-spirit-score: Show both teams spirit form if admin of both

d9c172e

scroll-button: Fix button not visible

6eb69b4

spirit-scores: Api for staff to enter self scores

63cebf8

spirit-scores: Add in form for staff to enter self scores

9bd21a9

Joe2k force-pushed the admin-cleanup branch from 49a1368 to 9bd21a9 Compare January 18, 2024 18:16

scroll-button: Replace help button position when not logged in

f091c2b

Joe2k requested a review from SibiAkkash January 18, 2024 18:31

Joe2k merged commit 5ed353d into main Jan 18, 2024
5 checks passed

punchagan deleted the admin-cleanup branch January 19, 2024 03:27

Provide feedback