Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show accreditation details #252

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Show accreditation details #252

merged 7 commits into from
Jan 12, 2024

Conversation

Joe2k
Copy link
Contributor

@Joe2k Joe2k commented Jan 10, 2024

Also fixed some bugs in player page and validate roster page

@Joe2k Joe2k requested review from punchagan and SibiAkkash January 10, 2024 08:38
@Joe2k
Copy link
Contributor Author

Joe2k commented Jan 10, 2024

Screenshot 2024-01-10 at 2 18 06 PM

Copy link
Contributor

@SibiAkkash SibiAkkash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we can merge this.

I feel the validate roster component is a bit long and nested, what do you think ?
I can break this component out to separate components in a different PR, might make it easier to maintain.

@punchagan
Copy link
Member

looks good, we can merge this.

Please go ahead and merge it, if you guys are happy with this. I won't be able to review PRs for a few more weeks.

I feel the validate roster component is a bit long and nested, what do you think ? I can break this component out to separate components in a different PR, might make it easier to maintain.

I'm all for refactoring for maintainability! Thanks Sibi!

@Joe2k Joe2k merged commit 1323253 into main Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants