Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rostering directly from email #375

Merged

Conversation

supergi0
Copy link
Contributor

@supergi0 supergi0 commented Sep 8, 2024

On Team Admin side

  • Encode invitation id and a key to a jwt
  • Create accept and decline links & corresponding buttons in email template & send email.

On Player side

  • Redirect to page, get the token and send call to backend to verify it.
  • Get invitation id and follow the same procedure as before.

To test

  • Set a EMAIL_SECRET_KEY environment variable.

Email ss

https://imgur.com/a/jj5QcC5

Series invitation error response UI

Series invitation accept UI

Series invitation decline UI

@supergi0 supergi0 changed the title Draft: Allow rostering directly from email Allow rostering directly from email Sep 8, 2024
@Joe2k Joe2k self-requested a review September 9, 2024 09:43
@SibiAkkash
Copy link
Contributor

Hi @supergi0, thanks for your contribution !

@punchagan
Copy link
Member

punchagan commented Sep 9, 2024

Thanks for taking the time to contribute, @supergi0 ! 🎉

I'd really appreciate if you also put in some more context into the commit messages. The PR description details the changes made, etc., but it would be nice to have the "why" and some more context about the changes in the PR, to make the commits more understandable.

I'll let @SibiAkkash and @Joe2k do the more detailed review, that they already seem to be doing.

Thanks again for the contribution!

@supergi0 supergi0 force-pushed the feat/accept_roster_invite_from_mail branch 2 times, most recently from ee00eb5 to 70999b7 Compare September 15, 2024 12:44
@supergi0 supergi0 requested a review from Joe2k September 15, 2024 14:34
@supergi0 supergi0 force-pushed the feat/accept_roster_invite_from_mail branch 4 times, most recently from 654a089 to 042aa69 Compare September 21, 2024 12:43
@Joe2k Joe2k force-pushed the feat/accept_roster_invite_from_mail branch from 042aa69 to b480f17 Compare October 2, 2024 05:04
@Joe2k Joe2k merged commit c5cbe78 into india-ultimate:main Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants