Merge pull request #550 from indirect/show-search-error

error nicely when searches fail
indirect · Oct 6, 2024 · 23f2d39 · 23f2d39
2 parents bf4b50f + 437d4b9
commit 23f2d39
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/app/controllers/posts_controller.rb b/app/controllers/posts_controller.rb
@@ -8,7 +8,12 @@ def search
     return redirect_to feed_posts_path if params[:q].blank?
 
     index
-    @posts = @posts.search(params[:q])
+    @posts = @posts.search(params[:q]).to_a
+    render :index
+  rescue ActiveRecord::StatementInvalid => e
+    raise(e) unless e.cause.is_a?(SQLite3::SQLException)
+
+    flash.now[:search_failed] = e.cause.message
     render :index
   end
 

diff --git a/app/views/posts/index.html.erb b/app/views/posts/index.html.erb
@@ -6,12 +6,16 @@
     <%= @feed.name %>
   </p>
 
-  <%= form_with url: search_feed_posts_path(@feed), method: :get, local: true, class: "flex mt-6 gap-4" do |form| %>
+  <%= form_with url: search_feed_posts_path(@feed), method: :get, local: true, class: "flex mt-6 mb-4 gap-4" do |form| %>
     <%= form.text_field :q, value: params[:q], class: "shadow-sm focus:ring-indigo-500 focus:border-indigo-500 block w-full sm:text-sm border-gray-300 rounded-md" %>
     <%= form.submit "Search posts", name: nil, class: "inline-flex justify-center py-2 px-4 border border-transparent shadow-sm text-sm font-medium rounded-md text-white bg-indigo-600 hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500" %>
   <% end %>
+  <%= tag.p(class: "mt-2 border-l-2 border-red-500 bg-red-50 pl-4 py-2 rounded") do %>
+    <b>Search Failed</b><br>
+    <%= flash[:search_failed] %>
+  <% end if flash.key?(:search_failed) %>
 
-  <ul id="posts" role="list" class="divide-y divide-gray-200 mt-8 bg-white shadow sm:rounded-md">
+  <ul id="posts" role="list" class="divide-y divide-gray-200 mt-4 bg-white shadow sm:rounded-md">
     <%= render @posts, cached: true %>
   </ul>
 </div>